Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(ru): Primary pages were translated to russian #852

Merged
merged 5 commits into from
Oct 11, 2023
Merged

i18n(ru): Primary pages were translated to russian #852

merged 5 commits into from
Oct 11, 2023

Conversation

Lootjs
Copy link
Contributor

@Lootjs Lootjs commented Oct 9, 2023

What kind of changes does this PR include?

  • Changes or translations of Starlight docs site content

Description

I would like to share my translation of some documentation pages into Russian.

  • Also, I've added Russian to the language selection block.
  • In addition, I've corrected some inaccurate translations into Russian in the UI.

image

Could someone add the hacktoberfest-accepted label? 👀

p.s here is my previous PR to Astro Docs

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 330607b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Oct 9, 2023 •
edited
Loading

👷 Deploy Preview for astro-starlight processing.

Name Link
🔨 Latest commit 330607b
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/652699be35549e0007dff931

@github-actions github-actions bot added 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package labels Oct 9, 2023
astrobot-houston
astrobot-houston reviewed Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@astrobot-houston astrobot-houston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@Lootjs
Copy link
Contributor Author

Lootjs commented Oct 9, 2023

Is it necessary to add changesets? 🤔

delucis
delucis reviewed Oct 11, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Lootjs! I can see one small change needed here, otherwise looks great 🙌

delucis
delucis approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Ready to launch 🚀

@delucis delucis added the hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest label Oct 11, 2023
delucis
delucis reviewed Oct 11, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, actually, just realised one more thing to check: links to docs.astro.build can also use the /ru/ link instead of /en/. Will update these before merging.

@delucis delucis merged commit 344c92e into withastro:main Oct 11, 2023
liruifengv pushed a commit to liruifengv/starlight that referenced this pull request Oct 11, 2023
@Lootjs @delucis @liruifengv
i18n(ru): Primary pages were translated to russian (withastro#852)
6096106 
Co-authored-by: Loot Nurakhmetov <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
delucis added a commit that referenced this pull request Oct 11, 2023
@delucis @Lootjs
Add missing changeset from #852
f33be7f 
Co-Authored-By: Loot N. <[email protected]>
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Oct 11, 2023
@HiDeoo
Merge branch 'main' into hd-docs-social-links
0057d1b 
* main:
  Add missing changeset from withastro#852
  i18n(zh-CN): fix another link to astro main doc (withastro#867)
  i18n(zh-CN): fix link to astro main doc (withastro#866)
  [i18nIgnore] i18n(zh-cn): Fix Chinese subtag (withastro#855)
@delucis delucis mentioned this pull request Oct 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

@astrobot-houston astrobot-houston astrobot-houston left review comments

Assignees
No one assigned
Labels
🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lootjs @delucis @astrobot-houston