Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Facebook and email icons #815

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Oct 6, 2023

What kind of changes does this PR include?

  • Changes or translations of Starlight docs site content
  • Changes to Starlight code

Description

This pull request adds a Facebook and email icons and includes them in the social icons options.

Note: Unicons does not have a dedicated icon for email but the 2 potential candidates are envelope and at. I picked envelope after searching here and seeing that most icon sets use an envelope for email.

@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2023

🦋 Changeset detected

Latest commit: 4bfaa44

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Oct 6, 2023 3:55pm

@netlify
Copy link

netlify bot commented Oct 6, 2023

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 4bfaa44
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/65202d8046c445000700a8aa
😎 Deploy Preview https://deploy-preview-815--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package labels Oct 6, 2023
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @HiDeoo 🙌

@delucis delucis added the 🌟 patch Change that triggers a patch release label Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Facebook and Email Icons
2 participants