add twitter new logo

[apinet]

What kind of changes does this PR include?

• Add an icon

Description

• Add the new twitter svg logo next to the older one.

[changeset-bot]

🦋 Changeset detected

Latest commit: 3ac828d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@astrojs/starlight	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✅ Deploy Preview for astro-starlight ready!

Name	Link
🔨 Latest commit	3ac828d
🔍 Latest deploy log	https://app.netlify.com/sites/astro-starlight/deploys/651b4336df80d3000843f81c
😎 Deploy Preview	https://deploy-preview-752--astro-starlight.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[HiDeoo]

Thanks for your contribution. 🙌

This changes makes me wonder a few things:

• Should this be added as a new logo or should it replace the current twitter one?
• Should this have an impact on the social media icons displayed in the site header?
• If yes, should twitter be renamed to x or both be kept?

Not sure what to think as x.com links redirects to twitter.com but twitter.com uses the new x logo on the official Twitter website, this is a bit confusing ^^ 🤔

[apinet]

If we replace twitter for x, we risk to break references to the old icon if some dev buddies used it directly. Maybe we could keep both for a few months and remove twitter icon after that?

Regarding social media icons I updated the pull request for supporting x as social media with the new icon and keeping twitter as is it.

[delucis]

Thanks for this @apinet! I think where you and @HiDeoo ended up makes sense for now, even if it is a bit odd having both, it lets people decide how much they want to humour the rebranding shenanigans 😅

One thing: I wonder if we should use x.com as the key here? We’ve discussed expanding our built-in icon support to include the full set of Unicons (the icon set Starlight uses currently) and it already includes a generic x icon that could clash. What do you think?

[HiDeoo]

One thing: I wonder if we should use x.com as the key here? We’ve discussed expanding our built-in icon support to include the full set of Unicons (the icon set Starlight uses currently) and it already includes a generic x icon that could clash. What do you think?

Sounds fine by me.

I guess the remaining missing changes after updating the key would be updating docs/src/content/docs/guides/customization.mdx & docs/src/content/docs/reference/configuration.md to document it and adding a changeset.

[apinet]

Hi @HiDeoo. I have updated customization & configuration files in all available languages. Let me know if I miss something but I think w're good :)

[HiDeoo]

Thanks for the update, this PR may requires a few changes:

• Following Chris' comment, we should use x.com for the icon key to avoid a potential clash with the x icon already existing in the Unicons set.
• Would you mind reverting the changes in d715b5f and only keep the changes for the English version (docs/src/content/docs/guides/customization.mdx & docs/src/content/docs/reference/configuration.md)? We usually only update the English pages and leave changes to the translations to our translators as this makes it easier for the Starlight translation tracker to keep track of the changes.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
starlight	✅ Ready (Inspect)	Visit Preview	Oct 2, 2023 10:27pm

[delucis]

Thanks again for your contribution @apinet! Hope you don’t mind I took the liberty of updating this PR with the last few changes so we can get this out in our next release.