Repository navigation
perf: optimize route and sidebar lookups - #4148
Merged
Merged
Conversation
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: 25022a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
delucis
previously approved these changes
Aug 25, 2026
delucis
left a comment
delucis
left a comment
Member
There was a problem hiding this comment.
These changes all make sense to me! Although it’s a bit hard to reason about exactly what the performance improvement will look like. Maybe as suggested by @HiDeoo on Discord we should wait to merge this after setting up some benchmarks so we can see clearly how we’ve improved.
Merged
Merging this PR will improve performance by ×30
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | sidebar |
11,853.8 µs | 70.1 µs | ×170 |
| ⚡ | route_data |
17 ms | 3.3 ms | ×5.2 |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing perf/routing-sidebar-lookups (25022a5) with main (dd7fb97)
delucis
approved these changes
Sep 1, 2026
delucis
left a comment
delucis
left a comment
Member
There was a problem hiding this comment.
Approving again because I added a changeset.
Member
Author
|
Ran the benchmarks on my machine:
|
Merged
HiDeoo
added a commit
to HiDeoo/starlight
that referenced
this pull request
Sep 2, 2026
* main: [i18nIgnore] Transpile Starlight packages (withastro#3572) i18n(ru): update translations (withastro#4170) [ci] release (withastro#4169) Fix hidden heading anchor links (withastro#4167) perf: optimize route and sidebar lookups (withastro#4148) chore: add benchmarks (withastro#4157)
dadezzz
pushed a commit
to dadezzz/university_notes
that referenced
this pull request
Sep 5, 2026
![Renovate [bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [@astrojs/starlight](https://starlight.astro.build) ([source](https://github.com/withastro/starlight/tree/HEAD/packages/starlight)) | [`0.41.10` → `0.41.11`](https://renovatebot.com/diffs/npm/@astrojs%2fstarlight/0.41.10/0.41.11) |  |  | --- ### Release Notes <details> <summary>withastro/starlight (@​astrojs/starlight)</summary> ### [`v0.41.11`](https://github.com/withastro/starlight/blob/HEAD/packages/starlight/CHANGELOG.md#04111) [Compare Source](https://github.com/withastro/starlight/compare/@astrojs/starlight@0.41.10...@astrojs/starlight@0.41.11) ##### Patch Changes - [#​4167](withastro/starlight#4167) [`32a5e29`](withastro/starlight@32a5e29) Thanks [@​HiDeoo](https://github.com/HiDeoo)! - Fixes a layout issue and anchor links appearing for hidden headings, e.g. footnote headings, when `markdown.headingLinks` is enabled or the `<AnchorHeading>` component is used. - [#​4148](withastro/starlight#4148) [`cdfafd8`](withastro/starlight@cdfafd8) Thanks [@​ematipico](https://github.com/ematipico)! - Optimizes sidebar data generation logic to speed up sites with large sidebars </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC42MS42IiwidXBkYXRlZEluVmVyIjoiNDQuNjEuNiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced repeated route and sidebar scans with maps, sets, and small caches. This reduces build work on documentation sites with many pages and avoids attaching unused route data to static paths.
This PR doesn't affect anything visual