Skip to content

Add Goodreads icon - #4145

Merged
delucis merged 2 commits into
withastro:mainfrom
pyxelr:add-goodreads-icon
Aug 25, 2026
Merged

Add Goodreads icon#4145
delucis merged 2 commits into
withastro:mainfrom
pyxelr:add-goodreads-icon

Conversation

@pyxelr

@pyxelr pyxelr commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Description

  • This PR adds a new feature which has been discussed and approved here.

Adds 1 new icon: goodreads.

The path is the monochrome Goodreads g mark on a 24x24 viewBox, taken from Simple Icons (CC0-1.0) and optimised with SVGOMG, per the guidance in #4135. It's the same path that was reviewed in the discussion.

Placed after tiktok, following where the recently added social icons have been landing.

@changeset-bot

changeset-bot Bot commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fe242ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@astrojs/starlight Patch
@e2e/basics Patch
@e2e/custom-src-dir Patch
@e2e/git Patch
@e2e/legacy-collections-backwards-compat Patch
@e2e/no-mdx-optimization Patch
@e2e/ssr Patch
starlight-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit fe242ef
🔍 Latest deploy log https://app.netlify.com/projects/astro-starlight/deploys/6a8d7be5b82bf50008485d48
😎 Deploy Preview https://deploy-preview-4145--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the 🌟 core Changes to Starlight’s main package label Aug 24, 2026
delucis
delucis requested changes Aug 25, 2026
View reviewed changes

@delucis delucis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pyxelr! Looks great — I left one suggestion to optimise the icon a little more but otherwise the PR is perfect 🙌

Comment thread packages/starlight/components-internals/Icons.ts Outdated
tiktok:
'<path d="M12.525.02c1.31-.02 2.61-.01 3.91-.02.08 1.53.63 3.09 1.75 4.17 1.12 1.11 2.7 1.62 4.24 1.79v4.03c-1.44-.05-2.89-.35-4.2-.97-.57-.26-1.1-.59-1.62-.93-.01 2.92.01 5.84-.02 8.75-.08 1.4-.54 2.79-1.35 3.94-1.31 1.92-3.58 3.17-5.91 3.21-1.43.08-2.86-.31-4.08-1.03-2.02-1.19-3.44-3.37-3.65-5.71-.02-.5-.03-1-.01-1.49.18-1.9 1.12-3.72 2.58-4.96 1.66-1.44 3.98-2.13 6.15-1.72.02 1.48-.04 2.96-.04 4.44-.99-.32-2.15-.23-3.02.37-.63.41-1.11 1.04-1.36 1.75-.21.51-.15 1.07-.14 1.61.24 1.64 1.82 3.02 3.5 2.87 1.12-.01 2.19-.66 2.77-1.61.19-.33.4-.67.41-1.06.1-1.79.06-3.57.07-5.36.01-4.03-.01-8.05.02-12.07z"/>',
goodreads:
'<path d="M17.346.026c.422-.083.859.037 1.179.325.346.284.55.705.557 1.153-.023.457-.247.88-.612 1.156l-2.182 1.748a.6.6 0 0 0-.255.43.52.52 0 0 0 .11.424 5.89 5.89 0 0 1 .832 6.58c-1.394 2.79-4.503 3.99-7.501 2.927a.8.8 0 0 0-.499-.01c-.224.07-.303.18-.453.383l-.014.02-.941 1.254s-.792.985.457.935c3.027-.119 3.817-.119 5.439-.01 2.641.18 3.806 1.903 3.806 3.275 0 1.623-1.036 3.383-3.809 3.383a118 118 0 0 0-5.517-.03c-.31.005-.597.013-.835.02-.228.006-.41.011-.52.011-.712 0-1.648-.186-1.66-1.068-.008-.729.624-1.12 1.11-1.172.43-.045.815.007 1.24.064.252.034.518.07.815.088.185.011.366.025.552.038.53.038 1.102.08 1.926.087.427.005.759.01 1.025.015.695.012.941.016 1.28-.015 1.248-.112 1.832-.61 1.832-1.376 0-.805-.584-1.264-1.698-1.414-1.564-.213-2.33-.163-3.72-.074a88 88 0 0 1-1.669.095c-.608.029-2.449.026-2.682-1.492-.053-.416-.073-1.116.807-2.325l.75-1.003c.36-.49.582-.898.053-1.559 0 0-.39-.468-.52-.638-1.215-1.587-1.512-4.08-.448-6.114 1.577-3.011 5.4-4.26 8.37-2.581.253.143.438.203.655.163.201-.032.27-.167.363-.344q.03-.06.067-.126c.004-.01.241-.465.535-1.028l.734-1.41a1.5 1.5 0 0 1 1.041-.785M9.193 13.243c1.854.903 3.912.208 5.254-2.47 1.352-2.699.827-5.11-1.041-6.023-2.488-1.213-4.596 1.081-5.389 2.66-1.355 2.698-.717 4.886 1.147 5.818Z"/>',

@delucis delucis Aug 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can compress this path a bit more:

Suggested change
'<path d="M17.346.026c.422-.083.859.037 1.179.325.346.284.55.705.557 1.153-.023.457-.247.88-.612 1.156l-2.182 1.748a.6.6 0 0 0-.255.43.52.52 0 0 0 .11.424 5.89 5.89 0 0 1 .832 6.58c-1.394 2.79-4.503 3.99-7.501 2.927a.8.8 0 0 0-.499-.01c-.224.07-.303.18-.453.383l-.014.02-.941 1.254s-.792.985.457.935c3.027-.119 3.817-.119 5.439-.01 2.641.18 3.806 1.903 3.806 3.275 0 1.623-1.036 3.383-3.809 3.383a118 118 0 0 0-5.517-.03c-.31.005-.597.013-.835.02-.228.006-.41.011-.52.011-.712 0-1.648-.186-1.66-1.068-.008-.729.624-1.12 1.11-1.172.43-.045.815.007 1.24.064.252.034.518.07.815.088.185.011.366.025.552.038.53.038 1.102.08 1.926.087.427.005.759.01 1.025.015.695.012.941.016 1.28-.015 1.248-.112 1.832-.61 1.832-1.376 0-.805-.584-1.264-1.698-1.414-1.564-.213-2.33-.163-3.72-.074a88 88 0 0 1-1.669.095c-.608.029-2.449.026-2.682-1.492-.053-.416-.073-1.116.807-2.325l.75-1.003c.36-.49.582-.898.053-1.559 0 0-.39-.468-.52-.638-1.215-1.587-1.512-4.08-.448-6.114 1.577-3.011 5.4-4.26 8.37-2.581.253.143.438.203.655.163.201-.032.27-.167.363-.344q.03-.06.067-.126c.004-.01.241-.465.535-1.028l.734-1.41a1.5 1.5 0 0 1 1.041-.785M9.193 13.243c1.854.903 3.912.208 5.254-2.47 1.352-2.699.827-5.11-1.041-6.023-2.488-1.213-4.596 1.081-5.389 2.66-1.355 2.698-.717 4.886 1.147 5.818Z"/>',
'<path d="M17.35.03c.42-.09.85.03 1.17.32q.54.45.56 1.15c-.02.46-.25.88-.61 1.16l-2.18 1.75a.6.6 0 0 0-.26.43.5.5 0 0 0 .11.42 5.9 5.9 0 0 1 .84 6.58 5.96 5.96 0 0 1-7.5 2.93 1 1 0 0 0-.5-.01c-.23.07-.3.18-.46.38l-.01.02-.94 1.26s-.8.98.45.93a40 40 0 0 1 5.44 0c2.64.17 3.8 1.9 3.8 3.27 0 1.62-1.03 3.38-3.8 3.38a118 118 0 0 0-5.52-.03l-.83.02-.52.01c-.71 0-1.65-.19-1.66-1.07-.01-.73.62-1.12 1.1-1.17.44-.05.82 0 1.25.06l.81.1q.28 0 .56.03c.53.04 1.1.08 1.92.09l1.03.01c.7.01.94.02 1.28-.01 1.24-.12 1.83-.61 1.83-1.38q-.02-1.2-1.7-1.41c-1.56-.22-2.33-.17-3.72-.08l-1.67.1c-.6.03-2.45.02-2.68-1.5-.05-.41-.07-1.11.8-2.32l.76-1c.36-.5.58-.9.05-1.56 0 0-.4-.47-.52-.64a5.9 5.9 0 0 1-.45-6.11 6.14 6.14 0 0 1 8.37-2.58c.25.14.44.2.66.16.2-.03.27-.17.36-.35l.07-.12.53-1.03.73-1.4a1.5 1.5 0 0 1 1.05-.8M9.19 13.25c1.86.9 3.92.21 5.26-2.47 1.35-2.7.82-5.1-1.04-6.02C10.9 3.54 8.8 5.83 8 7.41c-1.35 2.7-.71 4.89 1.15 5.82Z"/>',

I used the “number precision” in SVGOMG to check what the lowest precision would be that wouldn’t change appearance, so this rounds to 100ths of a pixel instead of 1,000ths with no visual impact.

@pyxelr pyxelr Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied, thank you! 🙌

I diffed the two renderings before committing to double-check the "no visual impact" claim — at 24px the max per-pixel delta is 13/255 with only 3 pixels above 8/255, so it's antialiasing-level noise. Even at 512px the shapes are structurally identical, just sub-pixel edge shifts. Nice 27.5% saving on the path (1251 → 907 bytes).

delucis
delucis approved these changes Aug 25, 2026
View reviewed changes

@delucis delucis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! Will merge and release this later today 🙌

@delucis
delucis merged commit 1c90d69 into withastro:main Aug 25, 2026
16 checks passed
This was referenced Aug 25, 2026
Merged
Closed
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Aug 25, 2026
@HiDeoo
Merge branch 'main' into hd/docs-3rd-party-content
3e6c5a0 
* main:
  [ci] release (withastro#4153)
  i18n(fr): update `resources/plugins.mdx` (withastro#4147)
  Add Goodreads icon (withastro#4145)
  [i18nIgnore] docs: update theme links (withastro#4152)
  i18n(de): update plugins.mdx (withastro#4151)
  i18n(ko-KR): update `plugins.mdx` (withastro#4146)
  [ci] release (withastro#4137)
  Fix localisation of Expressive Code UI (withastro#4138)
  chore: migrate Changesets to v3 (withastro#4139)
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Aug 25, 2026
@HiDeoo
Merge branch 'main' into hd/feat-satteri-0-10
53e68de 
* main:
  [ci] release (withastro#4153)
  i18n(fr): update `resources/plugins.mdx` (withastro#4147)
  Add Goodreads icon (withastro#4145)
  [i18nIgnore] docs: update theme links (withastro#4152)
  i18n(de): update plugins.mdx (withastro#4151)
  i18n(ko-KR): update `plugins.mdx` (withastro#4146)
pyxelr added a commit to pyxelr/pawelcislo.com that referenced this pull request Aug 25, 2026
@pyxelr
feat(portfolio): use the new built-in Goodreads icon
351ce0e 
Starlight 0.41.9 ships the goodreads icon added in withastro/starlight#4145,
so the open-book fallback is no longer needed.

- Bump @astrojs/starlight to 0.41.9 and astro to 7.2.6
- Raise the starlight floor to ^0.41.9 since the config now requires the icon
@pyxelr pyxelr mentioned this pull request Aug 25, 2026
Merged
dadezzz pushed a commit to dadezzz/university_notes that referenced this pull request Aug 30, 2026
Renovate [bot] Forgejo
fix(deps): update dependency @astrojs/starlight to v0.41.9 (#945)
5996e76 
This PR contains the following updates:

| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [@astrojs/starlight](https://starlight.astro.build) ([source](https://github.com/withastro/starlight/tree/HEAD/packages/starlight)) | [`0.41.8` → `0.41.9`](https://renovatebot.com/diffs/npm/@astrojs%2fstarlight/0.41.8/0.41.9) | ![age](https://developer.mend.io/api/mc/badges/age/npm/@astrojs%2fstarlight/0.41.9?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@astrojs%2fstarlight/0.41.8/0.41.9?slim=true) |

---

### Release Notes

<details>
<summary>withastro/starlight (@&#8203;astrojs/starlight)</summary>

### [`v0.41.9`](https://github.com/withastro/starlight/blob/HEAD/packages/starlight/CHANGELOG.md#0419)

[Compare Source](https://github.com/withastro/starlight/compare/@astrojs/starlight@0.41.8...@astrojs/starlight@0.41.9)

##### Patch Changes

- [#&#8203;4145](withastro/starlight#4145) [`1c90d69`](withastro/starlight@1c90d69) Thanks [@&#8203;pyxelr](https://github.com/pyxelr)! - Adds 1 new icon: `goodreads`

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC40OS4xIiwidXBkYXRlZEluVmVyIjoiNDQuNDkuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delucis delucis delucis approved these changes

Assignees

No one assigned

Labels

🌟 core Changes to Starlight’s main package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pyxelr @delucis