Repository navigation
Remove pagehide event from sidebar persistence script - #4088
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 3601b56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
delucis
changed the title
Contributor
size-limit report 📦
|
HiDeoo
approved these changes
Jul 21, 2026
HiDeoo
left a comment
HiDeoo
left a comment
Member
There was a problem hiding this comment.
Makes total sense to me and like you said, Safari 14.5 is way below our minimum supported version.
Great call 🧹
Merged
dadezzz
pushed a commit
to dadezzz/university_notes
that referenced
this pull request
Jul 26, 2026
![Renovate [bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [@astrojs/starlight](https://starlight.astro.build) ([source](https://github.com/withastro/starlight/tree/HEAD/packages/starlight)) | [`0.41.3` → `0.41.4`](https://renovatebot.com/diffs/npm/@astrojs%2fstarlight/0.41.3/0.41.4) |  |  | --- ### Release Notes <details> <summary>withastro/starlight (@​astrojs/starlight)</summary> ### [`v0.41.4`](https://github.com/withastro/starlight/blob/HEAD/packages/starlight/CHANGELOG.md#0414) [Compare Source](https://github.com/withastro/starlight/compare/@astrojs/starlight@0.41.3...@astrojs/starlight@0.41.4) ##### Patch Changes - [#​3936](withastro/starlight#3936) [`712eedd`](withastro/starlight@712eedd) Thanks [@​miichom](https://github.com/miichom)! - Fixes support for modifying Zod enums when passing an [`extend` option](https://starlight.astro.build/reference/frontmatter/#extend) to Starlight’s `docsSchema()` - [#​4092](withastro/starlight#4092) [`0896b91`](withastro/starlight@0896b91) Thanks [@​delucis](https://github.com/delucis)! - Fixes support for links containing a protocol like `mailto:` in the sidebar - [#​4088](withastro/starlight#4088) [`4486ba4`](withastro/starlight@4486ba4) Thanks [@​delucis](https://github.com/delucis)! - Simplifies Starlight’s client-side sidebar state persistence script slightly </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNzIuNiIsInVwZGF0ZWRJblZlciI6IjQzLjI3Mi42IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pagehideevent in our sidebar state persistence script.pageHidein the event name.pagehidewas due to Safari’s partialvisibilitychangesupport. According to MDN’s data Safari fixed this in April 2021 (v14.1 on desktop, v14.5 on mobile), so we no longer needpagehideto cover those older browsers which fall outside of our browser support matrix.