Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Visual Studio Code workspace settings being ignored #2275

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Sep 2, 2024

I learned yesterday that Visual Studio Code workspace settings (e.g. the docs/.vscode/ folder) are not working if they are not in the root of the workspace.

Opening the Starlight monorepo in Visual Studio Code and checking the available launch tasks does indeed confirm this behavior as no tasks are available.

SCR-20240902-oaxc

I never noticed that issue as I don't rely on Visual Studio Code to launch the debugger.

This PR moves the docs/.vscode/ folder to the root of the repository to fix the issue. Opening the monorepo in Visual Studio Code with this change applied now shows the available launch tasks.

SCR-20240902-obdv

I also updated the launch task to change the cwd to the docs folder so that setting breakpoints in the source code and starting the debugger works as expected.

SCR-20240902-obuu

Copy link

changeset-bot bot commented Sep 2, 2024

⚠️ No Changeset found

Latest commit: dfa92ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit dfa92ab
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/66d5c6a93cac5500085a0704
😎 Deploy Preview https://deploy-preview-2275--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I guess this makes sense — I never consciously configured these, so this is just the default config file that came from running create astro to scaffold the docs site. (It dates to the very first commit in this repo 😁)

Happy to move these to help folks who may not have the Astro extension already and could use these.

@delucis delucis merged commit b51a2e8 into withastro:main Sep 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants