Avoid sidebar scrollbar hiding behind navbar #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
🦋 Changeset detectedLatest commit: 5c830ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
|
Awesome, thanks for checking @TheOtterlord! |
Merged
HiDeoo
added a commit
to HiDeoo/starlight
that referenced
this pull request
Jan 15, 2024
* main: (55 commits) [ci] format i18n(es): Update `index` (withastro#1360) [ci] format i18n(fr): Update index (withastro#1367) i18n(es): remove extra section (withastro#1370) i18n(ko-KR): update `index.mdx` (withastro#1363) [ci] format i18n(zh-cn): Update index.mdx (withastro#1361) docs(showcase): add OpenSaaS.sh (withastro#1359) feat(Testimonials): add testimonials to website (withastro#1104) [ci] format [ci] release (withastro#1332) fix: autogenerated sidebar alphabetical sort (withastro#1298) Avoid sidebar scrollbar hiding behind navbar (withastro#1353) Use spawnSync instead of execaSync in `git.ts` (withastro#1347) [ci] format [i18nIgnore] Add src alias (withastro#1322) Italian translation for search.devWarning (withastro#1351) [ci] format i18n(pt-BR): Add translation for `guides/sidebar` (withastro#1346) ...
HiDeoo
added a commit
to HiDeoo/starlight
that referenced
this pull request
Jan 15, 2024
* main: (69 commits) [i18nIgnore] docs: `pnpm install` → `pnpm add` (withastro#1324) [ci] format i18n(zh-cn): Update frontmatter.mdx (withastro#1362) [ci] format i18n(es): Update `index` (withastro#1360) [ci] format i18n(fr): Update index (withastro#1367) i18n(es): remove extra section (withastro#1370) i18n(ko-KR): update `index.mdx` (withastro#1363) [ci] format i18n(zh-cn): Update index.mdx (withastro#1361) docs(showcase): add OpenSaaS.sh (withastro#1359) feat(Testimonials): add testimonials to website (withastro#1104) [ci] format [ci] release (withastro#1332) fix: autogenerated sidebar alphabetical sort (withastro#1298) Avoid sidebar scrollbar hiding behind navbar (withastro#1353) Use spawnSync instead of execaSync in `git.ts` (withastro#1347) [ci] format [i18nIgnore] Add src alias (withastro#1322) ...
HiDeoo
added a commit
to HiDeoo/starlight
that referenced
this pull request
Jan 15, 2024
* main: (62 commits) [i18nIgnore] docs: `pnpm install` → `pnpm add` (withastro#1324) [ci] format i18n(zh-cn): Update frontmatter.mdx (withastro#1362) [ci] format i18n(es): Update `index` (withastro#1360) [ci] format i18n(fr): Update index (withastro#1367) i18n(es): remove extra section (withastro#1370) i18n(ko-KR): update `index.mdx` (withastro#1363) [ci] format i18n(zh-cn): Update index.mdx (withastro#1361) docs(showcase): add OpenSaaS.sh (withastro#1359) feat(Testimonials): add testimonials to website (withastro#1104) [ci] format [ci] release (withastro#1332) fix: autogenerated sidebar alphabetical sort (withastro#1298) Avoid sidebar scrollbar hiding behind navbar (withastro#1353) Use spawnSync instead of execaSync in `git.ts` (withastro#1347) [ci] format [i18nIgnore] Add src alias (withastro#1322) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For sidebars that are long enough to scroll (e.g. Astro Docs or on smaller screens), the scrollbar currently spans the entire viewport height, meaning its top part is behind the nav bar.
Instead of using
padding-topto push sidebar content down into view, this PR usesinsetto position the sidebar directly at that point, so the the scrollbar is fully visible.I think this closes #1350 if I understood correctly.