Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(zh-CN): translate i18n.mdx #1190

Merged
merged 3 commits into from
Dec 1, 2023
Merged

i18n(zh-CN): translate i18n.mdx #1190

merged 3 commits into from
Dec 1, 2023

Conversation

Genteure
Copy link
Contributor

@Genteure Genteure commented Dec 1, 2023

Description

Update translation for guides/i18n.mdx.
Corresponding source file changes:

I also made some formatting changes and now the translated file is matching the English version line by line.

Copy link

changeset-bot bot commented Dec 1, 2023

⚠️ No Changeset found

Latest commit: 2da8314

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Dec 1, 2023 6:24pm

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Dec 1, 2023
};
```

在 Astro 文档的[“定义集合模式”](https://docs.astro.build/zh-cn/guides/content-collections/#定义集合模式)中了解有关内容集合 schema 的更多信息。
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

schema is left untranslated here because:

  • This is a pretty commonly used word in the context of frontend, typescript and databases so everyone should be able to easily understand what it means.
  • I kinda don't agree with the current translation of schema in Astro docs, technically "schema" can be translated to "模式" but I have never seen it being used this way in any documentation until I searched about it just now. "模式" is much more commonly being used to mean "mode".
  • I feel like translating it just for the sake of translating everything only ended up hurting readability.

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation 🙌

As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist. Thanks for clarifying for schema, I think you're the best to know if it's relevant/better to keep it in English or not and if at some point someone wants to translate it, this could be easily discussed in a new PR.

One tiny details, this is missing the highlight of the very first code block added in https://github.com/withastro/starlight/pull/1102/files#diff-4c65fc770580b991c60e2b800f0c7ed48935c7bf31959943e2118b7e243ed7c1R14 and unfortunately I cannot suggest a change as it's oustide of the reviewable area.

Except that, everything looks good to me 👍

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants