-
-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(zh-CN): translate i18n.mdx
#1190
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
}; | ||
``` | ||
|
||
在 Astro 文档的[“定义集合模式”](https://docs.astro.build/zh-cn/guides/content-collections/#定义集合模式)中了解有关内容集合 schema 的更多信息。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
schema
is left untranslated here because:
- This is a pretty commonly used word in the context of frontend, typescript and databases so everyone should be able to easily understand what it means.
- I kinda don't agree with the current translation of
schema
in Astro docs, technically "schema" can be translated to "模式" but I have never seen it being used this way in any documentation until I searched about it just now. "模式" is much more commonly being used to mean "mode". - I feel like translating it just for the sake of translating everything only ended up hurting readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the translation 🙌
As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist. Thanks for clarifying for schema
, I think you're the best to know if it's relevant/better to keep it in English or not and if at some point someone wants to translate it, this could be easily discussed in a new PR.
One tiny details, this is missing the highlight of the very first code block added in https://github.com/withastro/starlight/pull/1102/files#diff-4c65fc770580b991c60e2b800f0c7ed48935c7bf31959943e2118b7e243ed7c1R14 and unfortunately I cannot suggest a change as it's oustide of the reviewable area.
Except that, everything looks good to me 👍
Co-authored-by: HiDeoo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix.
Description
Update translation for
guides/i18n.mdx
.Corresponding source file changes:
extend
options to docs and i18n schemas #1162I also made some formatting changes and now the translated file is matching the English version line by line.