-
-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose localized UI strings in route data #1135
Conversation
🦋 Changeset detectedLatest commit: 6d9e44d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me and I think this properly address the linked issues.
One thing I want to note tho is that with this approach, if we ever move to i18next
or something similar with a more advanced t()
, we would not be able to use some of the advanced features like interpolation, formatting, plurals, context, etc. I don't really see us needing those features in the near future, but I just wanted to point that out.
I think if we ever do that, we could still expose those functions on the route data object. Technically this API could have just added |
Oh definitely, I meant "we would not be able to use some of the advanced features" while keeping the same API without additional changes like exposing |
Formatting is intentionally weird in this file to help simplify merging with #1135
Description
labels
property in Starlight’s route data object for each page.useTranslations()
and thet()
helper it returned.labels
instead of callinguseTranslations()
themselves.t.pick()
helper previously returned byuseTranslations()
is it is no longer used.