Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update various Expressive Code docs links #1119

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Nov 23, 2023

What kind of changes does this PR include?

  • Changes or translations of Starlight docs site content

Description

This PR updates various links to the Expressive Code documentation in guides/authoring-content.md which I think are wrong. I think I'm fairly sure about the first change and for the other two I'm less sure as this leads to two identical links but at least they link to the relevant examples.

Copy link

changeset-bot bot commented Nov 23, 2023

⚠️ No Changeset found

Latest commit: 3fa2363

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Nov 23, 2023 6:40pm

@github-actions github-actions bot added the 📚 docs Documentation website changes label Nov 23, 2023
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think you’re right — looks like better things to link to. We changed up the wording and examples slightly while editing, so could be that we deviated from the original link.

@HiDeoo HiDeoo merged commit a4b7b87 into withastro:main Nov 23, 2023
7 checks passed
@hippotastic
Copy link
Contributor

Thank you @HiDeoo! I should have paid more attention to the wording changes that caused the links to become incorrect. I'm fairly certain they did make sense at some point. Thank you very much for catching and promptly fixing that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants