Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(fr): update reference/configuration.mdx #1117

Merged
merged 3 commits into from
Nov 24, 2023
Merged

i18n(fr): update reference/configuration.mdx #1117

merged 3 commits into from
Nov 24, 2023

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Nov 23, 2023

What kind of changes does this PR include?

  • Changes or translations of Starlight docs site content

Description

This PR updates the french version of the reference/configuration.mdx page with the changes of #742 and #1102.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 23, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4e1ffab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Nov 23, 2023
@vercel Vercel
Copy link

vercel bot commented Nov 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Nov 24, 2023 10:31am

HiDeoo
HiDeoo commented Nov 23, 2023
View reviewed changes
docs/src/content/docs/fr/reference/configuration.mdx
**Par défaut :** `true`

Starlight utilise [Expressive Code](https://github.com/expressive-code/expressive-code/tree/main/packages/astro-expressive-code) pour afficher les blocs de code et ajouter le support pour mettre en évidence des portions d'exemples de code, ajouter des noms de fichiers aux blocs de code, et plus encore.
Consultez le [guide « Blocs de code »](/fr/guides/authoring-content/#blocs-de-code) pour apprendre à utiliser la syntaxe d'Expressive Code dans votre contenu Markdown et MDX.
Copy link
Member Author

@HiDeoo HiDeoo Nov 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link is currently broken in this PR, I'll update this comment with a reference to the PR fixing it.

Fixed with https://github.com/withastro/starlight/pull/1118/files#diff-f41c5aa1deae13f1e1ac4c60df00dd9c4abf2cb634f19b50be8c5c3551e1c209R182

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the branch now that #1118 has been merged and the link is working properly in the preview.

delucis
delucis approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ÇMSB ! 🌟

Read through and nothing stuck out to me as a non-native French speaker.

dreyfus92
dreyfus92 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@HiDeoo HiDeoo merged commit baaa987 into withastro:main Nov 24, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreyfus92 dreyfus92 dreyfus92 approved these changes

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HiDeoo @delucis @dreyfus92