You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes several broken links and makes sure links all point to the current locale (e.g. on /es/ pages, all relative links should be to /es/ versions of pages).
Caught the wrong-locale links with some RegExp searching in the project (e.g. find \]\(/(?!ru) in docs/src/content/docs/ru/).
P.S. I considered if we could integrate the link checker into the docs site but HiDeoo/starlight-links-validator#9 is blocking us currently from doing that I think.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
1 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: - View the detailed breakdown and full score reports
Yeah, I also played a little bit with it this morning as I had my head in the code while releasing a new version. The logic should be relatively straightforward altho I think the smart move is to wait for plugins so I can turn the integration into a plugin and easily have access to the Starlight config to check if the site is multilingual or not and check which locales are configured.
the smart move is to wait for plugins so I can turn the integration into a plugin and easily have access to the Starlight config to check if the site is multilingual or not and check which locales are configured.
Absolutely. I’d also love a rule to enforce use of same-language links, which were a bunch of what I’d caught… wait I guess I should make a feature request 😁
📚 docsDocumentation website changesi18nAnything to do with internationalization & translation efforts
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
i18n
What kind of changes does this PR include?
Description
/es/pages, all relative links should be to/es/versions of pages).\]\(/(?!ru)indocs/src/content/docs/ru/).P.S. I considered if we could integrate the link checker into the docs site but HiDeoo/starlight-links-validator#9 is blocking us currently from doing that I think.