Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(astro-check): remove unused fast-glob dep #944

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 26, 2024

Changes

I don't think it matters in practice since fast-glob is also used by astro and language-server, but this helps keep the exact deps used concise.

Testing

existing tests should pass

Docs

n/a

Copy link

changeset-bot bot commented Aug 26, 2024

⚠️ No Changeset found

Latest commit: 7c79beb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Princesseuh
Copy link
Member

The fast-glob usage in the language-server is wrong anyway, it'll have to get removed eventually. Thank you!

@Princesseuh Princesseuh merged commit 99ec87f into main Aug 28, 2024
0 of 4 checks passed
@Princesseuh Princesseuh deleted the check-no-fast-glob branch August 28, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants