Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add full reason for editor integration failing to load #676

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

Princesseuh
Copy link
Member

@Princesseuh Princesseuh commented Oct 30, 2023

Changes

Just a small thing. Editor integrations from Vue and Svelte can fail to load sometimes, previously we'd just output a generic message when we can show the entire error. This prevented users from debugging #652 on their end

Testing

N/A

Docs

N/A

@Princesseuh Princesseuh requested a review from a team as a code owner October 30, 2023 10:48
@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2023

🦋 Changeset detected

Latest commit: 6f4b443

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@astrojs/language-server Patch
astro-vscode Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Emanuele Stoppa <[email protected]>
@@ -1,7 +1,5 @@
# Contributing

> See the [overview video](https://www.loom.com/share/609f7b61795349328730f14e1ae2166e) on how the extension works.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This video is quite outdated now, thank you @matthewp for making it, it did help me back then 🫡

@Princesseuh Princesseuh merged commit 89d4613 into main Oct 30, 2023
3 of 4 checks passed
@Princesseuh Princesseuh deleted the fix/show-integration-load-reason branch October 30, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants