Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(de): update basics/astro-pages.mdx #9759

Merged
merged 37 commits into from
Nov 4, 2024

Conversation

trueberryless
Copy link
Contributor

@trueberryless trueberryless commented Oct 21, 2024

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Oct 21, 2024
Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ce1f870
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67291b72fdfa3d00081173a1
😎 Deploy Preview https://deploy-preview-9759--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Oct 21, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
de basics/astro-pages.mdx Localization changed, will be marked as complete.
de guides/rss.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Contributor Author

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix broken links

src/content/docs/de/basics/astro-pages.mdx Outdated Show resolved Hide resolved
src/content/docs/de/basics/astro-pages.mdx Outdated Show resolved Hide resolved
src/content/docs/de/basics/astro-pages.mdx Outdated Show resolved Hide resolved
src/content/docs/de/basics/astro-pages.mdx Outdated Show resolved Hide resolved
src/content/docs/de/basics/astro-pages.mdx Outdated Show resolved Hide resolved
@trueberryless
Copy link
Contributor Author

Important: The spacing of the <Since> component in the section ## Partielle Seiten (last h2 heading) looks really weird. It seems that the margins are not applied although the newlines should be correct in the translation. This needs futher investigation please!

@trueberryless
Copy link
Contributor Author

Nevermind, the spacing issues where resolved in #5765...

@trueberryless
Copy link
Contributor Author

For reviewer(s): Special translation for "the error's stack" in this context:

For example, you should avoid displaying the error's stack as it contains information about how your code is structured on the server.

Translation: "die gesamte Ursprungsverfolgung des Fehlers", because "Stapel" sounds weird in this context...

Du solltest zum Beispiel vermeiden, die gesamte Ursprungsverfolgung des Fehlers anzuzeigen, da sie Informationen darüber enthält, wie dein Code auf dem Server strukturiert ist.

@trueberryless trueberryless marked this pull request as ready for review October 22, 2024 18:17
Copy link
Contributor

@Maxframe Maxframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small typos. Great job again! 👍

src/content/docs/de/basics/astro-pages.mdx Outdated Show resolved Hide resolved
src/content/docs/de/basics/astro-pages.mdx Outdated Show resolved Hide resolved
src/content/docs/de/basics/astro-pages.mdx Outdated Show resolved Hide resolved
@trueberryless
Copy link
Contributor Author

Thanks you for reviewing! Much appreciated 👍

@yanthomasdev
Copy link
Member

Hey @trueberryless, there's a conflict here, could you take a look when you have the time? 🙌

@trueberryless
Copy link
Contributor Author

Sure, gimme 5min

@trueberryless
Copy link
Contributor Author

Got it: guides/markdown-content.mdx got completely deleted because it's too outdated in #9778
I just reverted all changes in this file...

@trueberryless
Copy link
Contributor Author

btw, thank you soooooo much for merging these PRs
this makes it easier to keep track of the files in the translation tracker and gives motivation to continue translate more files...

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work!

@yanthomasdev yanthomasdev merged commit c478fe4 into withastro:main Nov 4, 2024
10 checks passed
@trueberryless trueberryless deleted the bas-ast-pag branch November 4, 2024 19:16
@trueberryless
Copy link
Contributor Author

@yanthomasdev Do you know why the basics/astro-pages.mdx file is not marked as completed in Translation Tracker?

I mean I get that guides/rss.mdx shouldn't be marked as completed and I guess it's not possible to specify with Lunaria exactly which file to handle how, but yeah, I don't see any ignore keywords anywhere...

@yanthomasdev
Copy link
Member

Do you know why the basics/astro-pages.mdx file is not marked as completed in Translation Tracker?
Might be a bug, I'll take a look @trueberryless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants