Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-example-syntax] hippo-proof code examples #5364

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Conversation

sarah11918
Copy link
Member

Description (required)

Some changes to code snippet syntax (mostly titles) in preparation for Hippo's proposed changes to Expressive Code.

Ideally, we'd replace every code snippet in docs with the title="" syntax, but this is the minimum viable change for now to let @hippotastic make his changes.

Related issues & labels (optional)

Copy link

netlify bot commented Nov 11, 2023

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 0800cbf
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/65526f379d2e7700087210ac
😎 Deploy Preview https://deploy-preview-5364--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sarah11918 sarah11918 added the code snippet update Updates a code sample: typo, outdated code etc. label Nov 11, 2023
Copy link
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@hippotastic hippotastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, too! I see that you've even added titles to code blocks that were missing them before, so win-win! Great!

@sarah11918 sarah11918 merged commit 5ce13aa into main Nov 13, 2023
9 checks passed
@sarah11918 sarah11918 deleted the hippo-proofing branch November 13, 2023 19:08
yanthomasdev added a commit that referenced this pull request Nov 16, 2023
* i18n(fr)

Fix multiple file with PR #5364

* Update astro-pages.mdx

* Update astro-syntax.mdx

* Update routing.mdx

Addition of some missing parts

* Update routing.mdx

Fix L431

* Update sharing-state.mdx

* Update imports.mdx

Fix L220

* Update imports.mdx

Fix L224

* Update 3.mdx

Del blank L35

* Update routing.mdx

fix recipes link

* Update imports.mdx

Fix link L220

* Update src/content/docs/fr/guides/imports.mdx

Merci

Co-authored-by: Thomas Bnt <[email protected]>

* Update src/content/docs/fr/guides/imports.mdx

Co-authored-by: Thomas Bnt <[email protected]>

---------

Co-authored-by: Thomas Bnt <[email protected]>
Co-authored-by: Yan Thomas <[email protected]>
fhiromasa added a commit to fhiromasa/astro-docs that referenced this pull request Mar 3, 2024
[code-example-syntax] hippo-proof code examples (withastro#5364)
yanthomasdev added a commit that referenced this pull request Mar 5, 2024
* Update routing.mdx in ja

Modified to be similar to the English sample code in "Nested Pagination" section

* update routing.mdx in ja

[code-example-syntax] hippo-proof code examples (#5364)

* update routing.mdx in ja

fix: add spacing to 'added in' texts (#5765)

* update routing.mdx in ja

Add <ReadMore> component (#6267)

* Update routing.mdx in ja

Document new routing priority behavior (#6386)

* Update src/content/docs/ja/guides/routing.mdx

Co-authored-by: Shinya Fujino <[email protected]>

* Update src/content/docs/ja/guides/routing.mdx

Co-authored-by: Shinya Fujino <[email protected]>

* Update src/content/docs/ja/guides/routing.mdx

Co-authored-by: Shinya Fujino <[email protected]>

* Update src/content/docs/ja/guides/routing.mdx

Co-authored-by: Shinya Fujino <[email protected]>

* Update src/content/docs/ja/guides/routing.mdx

Co-authored-by: Shinya Fujino <[email protected]>

* Update src/content/docs/ja/guides/routing.mdx

Co-authored-by: Shinya Fujino <[email protected]>

---------

Co-authored-by: Shinya Fujino <[email protected]>
Co-authored-by: Yan <[email protected]>
trueberryless added a commit to trueberryless/withastro-docs that referenced this pull request Oct 22, 2024
trueberryless added a commit to trueberryless/withastro-docs that referenced this pull request Oct 30, 2024
yanthomasdev added a commit that referenced this pull request Nov 4, 2024
* update translation #5364

* update translation #5572

* update translation #8585

* update translation #9082

---------

Co-authored-by: Yan <[email protected]>
yanthomasdev added a commit that referenced this pull request Nov 4, 2024
* update translation #1442

* update translation #1434

* update translation #1510

* update translation #1538

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* update translation #1638

* update translation #2091

* update translation #2133

* update translation #2409

* update translation #2371

* update translation #4610

* update translation #5128

* update translation #5205

* update translation #5240

* update translation #5364

* update translation #5765

* update translation #6267

* remove paragraph where I cant find when it was deleted in original version

* update translation #6620

* update translation #8495

* update translation #8573

* update translation #9336

* update translation #9336 2/2

didnt save file locally, so git didnt add

* fix all visual differences by comparing manually against original english version

* fix broken links in `astro-pages.mdx`

* Breaking changes to other files! fixing links which link to the �stro-pages.mdx file

* but now...

* Update src/content/docs/de/basics/astro-pages.mdx

Co-authored-by: Max <[email protected]>

* Update src/content/docs/de/basics/astro-pages.mdx

Co-authored-by: Max <[email protected]>

* Update src/content/docs/de/basics/astro-pages.mdx

Co-authored-by: Max <[email protected]>

* revert Update markdown-content.mdx

@lunaria-track:src/content/docs/de/basics/astro-pages.mdx

---------

Co-authored-by: Max <[email protected]>
Co-authored-by: Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code snippet update Updates a code sample: typo, outdated code etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants