import and use ImportMetaEnv component #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@bholmesdev - please check this, and adjust as necessary to get it to render properly. This might require fiddling, but the ideas are: 1. Where ever you're seeing {{}} in the preview render instead of import.meta.env, then you need to import (I've done) and use (I've done) this component instead of typing the phrase out directly. The rest of the expression can be passed as the`path=" "` attribute, and it will be formatted as code. 2. This component must be inside an HTML element, and can't be written inside regular Markdown. I've tried the simplest version first (just <p> tags around the line it's in). If this isn't sufficient, or screws up the rest of the rendering, then you'll have to "work your way out" converting larger and larger chunks to HTML until you have the rendering you need. (Or, you figure out whether it's ABSOLUTELY NECESSARY to write the phrase import.meta.env. Dealer's choice.) Hope this helps.
|
@bholmesdev Of the 3 places it's typed, this is the only one that IS a problem in the deploy preview, as far as I can tell? Can you check this really closely?
(The PR I made to your branch should detail how to fix that, at least in theory....) |
|
The two other places, in a code fence but yet not commented out ( 🤪 ) seem to be fine:
|
bholmesdev
added a commit
that referenced
this pull request
May 5, 2022
* edit: make RSS canonicalUrl required * refactor: rename "canonicalUrl" to "site" * import and use ImportMetaEnv component (#454) @bholmesdev - please check this, and adjust as necessary to get it to render properly. This might require fiddling, but the ideas are: 1. Where ever you're seeing {{}} in the preview render instead of import.meta.env, then you need to import (I've done) and use (I've done) this component instead of typing the phrase out directly. The rest of the expression can be passed as the`path=" "` attribute, and it will be formatted as code. 2. This component must be inside an HTML element, and can't be written inside regular Markdown. I've tried the simplest version first (just <p> tags around the line it's in). If this isn't sufficient, or screws up the rest of the rendering, then you'll have to "work your way out" converting larger and larger chunks to HTML until you have the rendering you need. (Or, you figure out whether it's ABSOLUTELY NECESSARY to write the phrase import.meta.env. Dealer's choice.) Hope this helps. Co-authored-by: Ben Holmes <[email protected]> * fix: slay import.meta.env demon the cheap way * chore: remove unused import Co-authored-by: Sarah Rainsberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bholmesdev - please check this, and adjust as necessary to get it to render properly. This might require fiddling, but the ideas are:
Where ever you're seeing
{{}}in the preview render instead ofimport.meta.env, then you need to import (I've done) and use (I've done) this component instead of typing the phrase out directly. The rest of the expression can be passed as thepath=" "attribute, and it will be formatted as code.This component must be inside an HTML element, and can't be written inside regular Markdown. I've tried the simplest version first (just
<p>tags enclosing the single line it's in). If this isn't sufficient, or screws up the rest of the rendering, then you'll have to "work your way out" converting larger and larger chunks to HTML until you have the rendering you need.(Or, you figure out whether it's ABSOLUTELY NECESSARY to write the phrase import.meta.env. Dealer's choice.) Hope this helps.