Edit: make RSS canonicalUrl required #453
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
import.meta.env.HELL -- I will check the deploy preview when it's ready, fix this if it needs, in one go, and with ALL the proper surrounding HTML required to make the component work. :/ |
|
@sarah11918 Deploy preview looks fine to me! Shouldn't be a problem in a code fence from my understanding, since Shiki chops up the import into |
|
@bholmesdev Gah! I replied in the other PR by mistake... short version, this is what this current Netlify deploy preview looks like: Can you look carefully at this? Because this is what I see: When it's in commented out code in the code fence, you're gonna need that component (as I gave instructions for dealing with, in the other PR): When it's just a string in the code fence, it seems to be fine: |
@bholmesdev - please check this, and adjust as necessary to get it to render properly. This might require fiddling, but the ideas are: 1. Where ever you're seeing {{}} in the preview render instead of import.meta.env, then you need to import (I've done) and use (I've done) this component instead of typing the phrase out directly. The rest of the expression can be passed as the`path=" "` attribute, and it will be formatted as code. 2. This component must be inside an HTML element, and can't be written inside regular Markdown. I've tried the simplest version first (just <p> tags around the line it's in). If this isn't sufficient, or screws up the rest of the rendering, then you'll have to "work your way out" converting larger and larger chunks to HTML until you have the rendering you need. (Or, you figure out whether it's ABSOLUTELY NECESSARY to write the phrase import.meta.env. Dealer's choice.) Hope this helps. Co-authored-by: Ben Holmes <[email protected]>
|
Totally understood! Thanks for walking through this nuanced / wacky issue @sarah11918 🙏 |
We discovered that
canonicalUrldid not work as expected in the@astrojs/rsspackage. So, we're asking users to apply this value manually as a required prop.Changes made
canonicalUrloption tositeimport.meta.env.SITEonly works in the latest 1.0 betasiteto all code examples, with explainer comments where applicable