Skip to content

i18n(de): update deploy guide, deno.mdx - #13731

Merged
ArmandPhilippot merged 4 commits into
withastro:mainfrom
deining:i18n/guides/deploy/deno.mdx
Jun 23, 2026
Merged

i18n(de): update deploy guide, deno.mdx#13731
ArmandPhilippot merged 4 commits into
withastro:mainfrom
deining:i18n/guides/deploy/deno.mdx

Conversation

@deining

@deining deining commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Description (required)

Related issues & labels (optional)

  • Suggested label: i18n

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Apr 14, 2026
@netlify

netlify Bot commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown

❌ Deploy Preview for astro-docs-2 failed. Why did it fail? →

Built without sensitive environment variables

Name Link
🔨 Latest commit dec360b
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/6a31b5241e3ace0009bb197e

@astrobot-houston

astrobot-houston commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
de/guides/deploy/deno.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@deining
deining force-pushed the i18n/guides/deploy/deno.mdx branch from a105998 to ad01a96 Compare June 5, 2026 18:36
@deining

deining commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Just rebased this PR, all checkers are green.
Friendly reminder: can you have a look at my PR, please?

@ArmandPhilippot

ArmandPhilippot commented Jun 16, 2026

Copy link
Copy Markdown
Member

Sorry for the delay! I don't speak German so I asked on Discord if there are volunteers to help here! We'll sort this out soon. Thank you for your patience and help! 🙌🏽

trueberryless
trueberryless reviewed Jun 16, 2026
View reviewed changes

@trueberryless trueberryless left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but I'll have to take a more close look before approving.

One thing I noticed throughout all changes:

You often write the informal form with upper case first letter, but we consistently use the lower case form, e.g.:

Please do it like that:

du; deinem; ...

instead of:

Du; Deinem; ...

(except the beginning of a sentence of course)

@deining
deining force-pushed the i18n/guides/deploy/deno.mdx branch 2 times, most recently from 16ce4c3 to dec360b Compare June 16, 2026 20:42
@deining

deining commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Please do it like that:

du; deinem; ...

instead of:

Du; Deinem; ...

Thanks for pointing that out, changed in all occurrences.
Thanks for your comment and your upcoming review!

@deining
deining requested a review from trueberryless June 16, 2026 20:45
@github-actions

github-actions Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Preview deployment

✅ Deployment complete!

randomguy-2650
randomguy-2650 approved these changes Jun 22, 2026
View reviewed changes

@randomguy-2650 randomguy-2650 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left just a nit… I personally think “Site” itself sounds weird.

Comment thread src/content/docs/de/guides/deploy/deno.mdx Outdated
Comment thread src/content/docs/de/guides/deploy/deno.mdx Outdated
Comment thread src/content/docs/de/guides/deploy/deno.mdx Outdated
Comment thread src/content/docs/de/guides/deploy/deno.mdx Outdated
@trueberryless

trueberryless commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Sorry, I didn't have the time to review this yet. You don't need to wait for my review if randomguy approves, I can take a look at the earliest in 2 weeks...

@deining
deining force-pushed the i18n/guides/deploy/deno.mdx branch from dec360b to 85c5e88 Compare June 23, 2026 17:38
@deining
deining requested a review from randomguy-2650 June 23, 2026 17:40
@deining

deining commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Left just a nit… I personally think “Site” itself sounds weird.

I agree. I change all occurrences from Astro-Site to Astro-Website, as suggested.

randomguy-2650
randomguy-2650 approved these changes Jun 23, 2026
View reviewed changes

@randomguy-2650 randomguy-2650 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! 🚀

trueberryless
trueberryless suggested changes Jun 23, 2026
View reviewed changes

@trueberryless trueberryless left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks really good to me 👏

I just found a little suggestion:

Comment thread src/content/docs/de/guides/deploy/deno.mdx Outdated
@deining
deining requested a review from trueberryless June 23, 2026 18:55
trueberryless
trueberryless approved these changes Jun 23, 2026
View reviewed changes

@trueberryless trueberryless left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update.

Everything looks good to me 🥳

@ArmandPhilippot

ArmandPhilippot commented Jun 23, 2026

Copy link
Copy Markdown
Member

Thank you all for your help, much appreciated! 💜

@ArmandPhilippot
ArmandPhilippot merged commit 6ee72e3 into withastro:main Jun 23, 2026
9 of 10 checks passed
@deining
deining deleted the i18n/guides/deploy/deno.mdx branch June 23, 2026 21:22
HiDeoo added a commit that referenced this pull request Jun 24, 2026
@HiDeoo
Merge branch 'main' into hd/satteri
aa8eecd 
* main:
  i18n(de): update deploy guide, deno.mdx (#13731)
  i18n(fr): update `guides/routing.mdx` (#14127)
  i18n(fr): update `configuration-reference.mdx` (#14126)
  i18n(ru): add new translations (#13842)
  i18n(ru): add `guides/environment-variables.mdx` (#13929)
tarikrital pushed a commit to tarikrital/astro-docs that referenced this pull request Jul 6, 2026
@deining @ArmandPhilippot
@trueberryless @randomguy-2650 @tarikrital
i18n(de): update deploy guide, deno.mdx (withastro#13731)
549ef78 
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: trueberryless <99918022+trueberryless@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@trueberryless trueberryless trueberryless approved these changes
@randomguy-2650 randomguy-2650 randomguy-2650 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@deining @astrobot-houston @ArmandPhilippot @trueberryless @randomguy-2650