-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
i18n(fr): fonts.mdx
#13042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(fr): fonts.mdx
#13042
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🙌🏽 I left some suggestions, mostly around the translation for "support" and because of missing translations in the API blocks.
We tend to avoid anglicisms, and in French "supporter" doesn't have the same meaning. In the French i18n guide, you can see the following recommendations:
to support (quelque chose) | prendre en charge / être compatible avec / fonctionner sous | Précédente discussion : #11795 (comment)
to support (une personne) | assister | Précédente discussion : #11795 (comment)
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions were bugged probably because of GitHub new experience... so I resolved my previous comments and here's the new suggestions!
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
|
Thank you for the detailed review @ArmandPhilippot ! I'm still not sure about this part : -available for the unifont Google Icons options
+available for the unifont Google Icons providerShould we commit changes only in French or also in the original version ? |
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ld-web, everything looks good to me! Since, you said you were okay with my suggestion I applied it (+ the missing one for a verb agreement and the API blocks that were resolved but not applied). I hope you don't mind, I don't think this requires more back and forth. 😄
Should we commit changes only in French or also in the original version ?
Only in French, if the English must be updated this should be done in a separate PR. But as I said, maybe that's not important. As you wish!
|
Yeah, all good ! Thanks for carefully reviewing ! 🙌🏻 Happy new year ! |
|
Thanks, happy new year to you too! And glad to see that you're still here to help with translations in this new year! 😄 |
Description (required)
Adds changes from #13025 and #13035 to the French translation of
reference/experimental-flags/fonts.mdxRelated issues & labels (optional)
Suggested label: i18n