Skip to content

Conversation

@ld-web
Copy link
Contributor

@ld-web ld-web commented Jan 13, 2026

Description (required)

Adds changes from #13025 and #13035 to the French translation of reference/experimental-flags/fonts.mdx

Related issues & labels (optional)
Suggested label: i18n

@netlify
Copy link

netlify bot commented Jan 13, 2026

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f1cf6de
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/696675360fabeb000890c5f0
😎 Deploy Preview https://deploy-preview-13042--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jan 13, 2026
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jan 13, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
fr/reference/experimental-flags/fonts.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙌🏽 I left some suggestions, mostly around the translation for "support" and because of missing translations in the API blocks.

We tend to avoid anglicisms, and in French "supporter" doesn't have the same meaning. In the French i18n guide, you can see the following recommendations:

to support (quelque chose) | prendre en charge / être compatible avec / fonctionner sous | Précédente discussion : #11795 (comment)
to support (une personne) | assister | Précédente discussion : #11795 (comment)

Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions were bugged probably because of GitHub new experience... so I resolved my previous comments and here's the new suggestions!

@ld-web
Copy link
Contributor Author

ld-web commented Jan 13, 2026

Thank you for the detailed review @ArmandPhilippot !

I'm still not sure about this part :

-available for the unifont Google Icons options
+available for the unifont Google Icons provider

Should we commit changes only in French or also in the original version ?

Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ld-web, everything looks good to me! Since, you said you were okay with my suggestion I applied it (+ the missing one for a verb agreement and the API blocks that were resolved but not applied). I hope you don't mind, I don't think this requires more back and forth. 😄

Should we commit changes only in French or also in the original version ?

Only in French, if the English must be updated this should be done in a separate PR. But as I said, maybe that's not important. As you wish!

@ArmandPhilippot ArmandPhilippot merged commit 1ecff79 into withastro:main Jan 13, 2026
10 checks passed
@ld-web
Copy link
Contributor Author

ld-web commented Jan 13, 2026

Yeah, all good ! Thanks for carefully reviewing ! 🙌🏻

Happy new year !

@ArmandPhilippot
Copy link
Member

Thanks, happy new year to you too! And glad to see that you're still here to help with translations in this new year! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants