Skip to content

feat(fonts): update font provider API #13025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
florian-lefebvre merged 7 commits into from
Jan 12, 2026
Merged

feat(fonts): update font provider API #13025

florian-lefebvre merged 7 commits into from
Jan 12, 2026

Conversation

@florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Jan 8, 2026 •
edited
Loading

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 5.16.9. See astro PR #15130.

@netlify
Copy link

netlify bot commented Jan 8, 2026 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 165c78f
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/69626a7ffeac64000778958a
😎 Deploy Preview https://deploy-preview-13025--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@florian-lefebvre florian-lefebvre mentioned this pull request Jan 8, 2026
Merged
3 tasks
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jan 8, 2026 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/experimental-flags/fonts.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@florian-lefebvre florian-lefebvre marked this pull request as ready for review January 8, 2026 11:17
@Fryuni
Copy link
Member

Fryuni commented Jan 8, 2026

Providing epic docs!! T&D gang!!!

sarah11918
sarah11918 reviewed Jan 8, 2026
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Florian! I'm so glad we all talked about this on Talking and Doc'ing! Here are some comments based on the revisions!

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Jan 8, 2026
@florian-lefebvre @sarah11918
Apply suggestions from code review
ba00adf 
Co-authored-by: Sarah Rainsberger <[email protected]>
florian-lefebvre
florian-lefebvre commented Jan 9, 2026
View reviewed changes
sarah11918
sarah11918 approved these changes Jan 9, 2026
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good now! 🎉

yanthomasdev
yanthomasdev reviewed Jan 10, 2026
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small nits from me and then LGTM

@florian-lefebvre florian-lefebvre merged commit 2b9e8c5 into main Jan 12, 2026
10 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/fonts-updated-provider-api-2 branch January 12, 2026 13:46
@jsparkdev jsparkdev mentioned this pull request Jan 13, 2026
Merged
@ld-web ld-web mentioned this pull request Jan 13, 2026
Merged
maxchang3 added a commit to mcontrib/docs that referenced this pull request Jan 15, 2026
@maxchang3
feat(fonts): update font provider API (withastro#13025)
8812edb
@maxchang3 maxchang3 mentioned this pull request Jan 15, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yanthomasdev yanthomasdev yanthomasdev left review comments

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees

No one assigned

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@florian-lefebvre @astrobot-houston @Fryuni @sarah11918 @yanthomasdev