Skip to content

Conversation

ArmandPhilippot
Copy link
Member

@ArmandPhilippot ArmandPhilippot commented Oct 10, 2025

Description (required)

  • Adds missing slashes to links in Unit 3.3: we had them in Unit 3.1 and they are back in Unit 5.3.
  • Fixes a Typescript error in Unit 3.4: the script in index.astro requires optional chaining and the setAttribute value should be a string.
    This is flagged by Typescript because the default preset is strict and we don't tell people to switch to basics in Unit 1.2.
    Note that this is no longer an issue once moved to scripts/menu.js but I kept the same code to avoid any confusion or extra wording.
  • Reorders MarkdownPostLayout.astro frontmatter data in Unit 5.3: Unit 4-2 and Unit 4-3 use a different order, we had the frontmatter.description between the date and the author.
  • Reorders frontmatter data in Unit 6.3: Unit 2.4 used a different order

Except the Typescript error, this is mostly nits... But this could be confusing for beginners when they check if their files are correct!

Related issues & labels (optional)

@ArmandPhilippot ArmandPhilippot added the code snippet update Updates a code sample: typo, outdated code etc. label Oct 10, 2025
Copy link

netlify bot commented Oct 10, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5e8560e
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/68ea619a9afa4e0008c6801d
😎 Deploy Preview https://deploy-preview-12532--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Oct 10, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/tutorial/3-components/3.mdx Source changed, localizations will be marked as outdated.
en/tutorial/3-components/4.mdx Source changed, localizations will be marked as outdated.
en/tutorial/5-astro-api/3.mdx Source changed, localizations will be marked as outdated.
en/tutorial/6-islands/3.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! All looks great!

@sarah11918 sarah11918 added tutorial Content/UI for the Build a Blog Tutorial Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Oct 11, 2025
@ArmandPhilippot ArmandPhilippot merged commit ce803f0 into withastro:main Oct 11, 2025
10 checks passed
@ArmandPhilippot ArmandPhilippot deleted the fix/tutorial branch October 11, 2025 14:08
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Oct 12, 2025
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Oct 12, 2025
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Oct 12, 2025
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Oct 12, 2025
ArmandPhilippot added a commit that referenced this pull request Oct 12, 2025
Signed-off-by: Thomas Bonnet <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! tutorial Content/UI for the Build a Blog Tutorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants