-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(tutorial): prevent Typescript error + tiny data reordering #12532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! All looks great!
Signed-off-by: Thomas Bonnet <[email protected]>
Signed-off-by: Thomas Bonnet <[email protected]>
Signed-off-by: Thomas Bonnet <[email protected]>
Signed-off-by: Thomas Bonnet <[email protected]>
Signed-off-by: Thomas Bonnet <[email protected]> Co-authored-by: Armand Philippot <[email protected]>
Description (required)
index.astro
requires optional chaining and thesetAttribute
value should be a string.This is flagged by Typescript because the default preset is
strict
and we don't tell people to switch tobasics
in Unit 1.2.Note that this is no longer an issue once moved to
scripts/menu.js
but I kept the same code to avoid any confusion or extra wording.MarkdownPostLayout.astro
frontmatter data in Unit 5.3: Unit 4-2 and Unit 4-3 use a different order, we had thefrontmatter.description
between thedate
and theauthor
.Except the Typescript error, this is mostly nits... But this could be confusing for beginners when they check if their files are correct!
Related issues & labels (optional)
code snippet update
blog-tutorial-demo
branches updates: