fix(complete): update deps, clean up & fix mismatches with docs #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was about to update the
content-collections
branch because we're missing the last changes... but I noticed we had a few remains from older Astro versions (.env.d.ts, favicon) in this branch. So, I followed the tutorial from scratch (while keeping the git history and the few additional files likeLICENSE
) to check if we missed anything.Changes
[email protected]
>[email protected]
)pnpm-lock.yaml
(we had bothpackage-lock.json
andpnpm-lock.yaml
; we should only have one them and not everyone usepnpm
)src/env.d.ts
, this is no longer needed and this no longer auto-generatedcreate astro
).vscode
(auto-generated bycreate astro
).gitignore
to match what is generated bycreate astro
src/pages/about.astro
:My skills are:
)src/layouts/MarkdownPostLayout.astro
: we had thefrontmatter.description
between thedate
and theauthor
in Unit 4-2 and Unit 4-3 and there was no empty lines. (Unit 5-3 should be fixed in the docs)src/components/Social.astro
await
insrc/pages/blog.astro
and reorder frontmatter data to match Unit 5.1strict
preset. This is no longer an issue once inmenu.js
but to avoid extra wording or confusion while following the tutorial, I updatedsrc/scripts/menu.js
with the Typescript fix.Questions:
content-collections
branch has a.gitpod.yml
file but not thecomplete
branch, should this file be in both or none?content-collections
branch has aOpen in Stackblitz
button in the README, should we add a similar button to thecomplete
branch?Tests
I've checked on Linux using both Firefox and Chromium and no issues in
dev
andpreview
!