Skip to content

Conversation

randomguy-2650
Copy link
Contributor

@randomguy-2650 randomguy-2650 commented Oct 5, 2025

Description

This PR changes the German sidebar configuration to remove the ­ HTML entity with the soft hyphen character, as the Astro sidebar does not render HTML entities, so it looks awkward.

Screenshots

Screenshot of Starlight sidebar in Astro docs in the German language, depicting a rendering error, thinking that the soft hyphen HTML entity renders in the sidebar, which it doesn’t

Related labels

  • Suggested label: i18n, hacktoberfest-accepted

Hacktoberfest 🎃

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Oct 5, 2025
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Oct 5, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
src/content/nav/de.ts Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link

netlify bot commented Oct 5, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9c533d4
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/68ea75b1c8ad9100082c14b5
😎 Deploy Preview https://deploy-preview-12506--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@trueberryless
Copy link
Contributor

Let's not forget to add the Hacktoberfest label (just as a friendly reminder) 😉

@yanthomasdev yanthomasdev added the hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest label Oct 11, 2025
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yanthomasdev yanthomasdev merged commit f46683e into withastro:main Oct 11, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants