Prevent <style> from getting moved in <html>
#974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8ec1d44 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
MoustaphaDev
commented
Mar 2, 2024
| @@ -902,8 +902,10 @@ func inHeadIM(p *parser) bool { | |||
| p.im = afterHeadIM | |||
| return true | |||
| case a.Body, a.Html, a.Br: | |||
| p.parseImpliedToken(EndTagToken, a.Head, a.Head.String()) | |||
There was a problem hiding this comment.
The fix was to remove this divergence from the html spec in the inHead insertion mode, see the "anything else" section to find the correct steps to be performed
|
I wanted to get more tests to cover all issues opened about this bug, but besides that yeah. I can't work on it right now though unfortunately |
|
I added a fair number of tests though so feel free to push it forward! |
Princesseuh
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Added json test to ensure a correct AST
Added tsx tests to ensure a correct result
Docs
N/A bug fix only