Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compressHTML logic #916

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update compressHTML logic #916

wants to merge 1 commit into from

Conversation

natemoo-re
Copy link
Member

Changes

Testing

I'd really love more comprehensive tests for this before we merge

Docs

Bug fix only

Copy link

changeset-bot bot commented Dec 20, 2023

🦋 Changeset detected

Latest commit: a7bae79

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@natemoo-re
Copy link
Member Author

!preview compact

Copy link
Contributor

 > [email protected] release /home/runner/work/compiler/compiler > changeset publish "--tag" "next--compact" 🦋 warn ===============================IMPORTANT!=============================== 🦋 warn Packages will be released under the next--compact tag 🦋 warn ---------------------------------------------------------------------- 🦋 info npm info @astrojs/compiler 🦋 info @astrojs/compiler is being published because our local version (0.0.0-compact-20231220212312) has not been published on npm 🦋 info Publishing "@astrojs/compiler" at "0.0.0-compact-20231220212312" 🦋 success packages published successfully: 🦋 @astrojs/[email protected] 🦋 Creating git tag... 🦋 New tag: @astrojs/[email protected]

@florian-lefebvre
Copy link
Member

It seems that it doesn't fix whitespaces (florian-lefebvre/portfolio#8): https://portfolio-1qbg5y00j-florian-lefebvre.vercel.app/

@natemoo-re
Copy link
Member Author

Thanks for confirming, @florian-lefebvre! I'm picking this up again.

@florian-lefebvre
Copy link
Member

@natemoo-re up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meaningful whitespace collapsed with compressHTML: true
2 participants