Remove site and projectRoot options #693
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #692
Remove
site
andprojectRoot
options, in favour ofinjectGlobals
option which is more generic (Name could be changed 🤔 ), e.g.The compiler would output
$$createAstro("https://astro.build")
. This allows us to pass params dynamically tocreateAstro
without leaking business logic that gets added to, e.g.Astro.site
.Further discussion on discord: https://discord.com/channels/830184174198718474/1060212452756815954/1060564993768169542
Note this change goes in hand to this Astro code: https://github.com/withastro/astro/blob/6a95790b45114e2e9fae65f513c6c9381ccdf376/packages/astro/src/runtime/server/astro-global.ts#L19-L32
Testing
Updated the test to cover this new option.
Docs
n/a