Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow script/style before html #666

Merged
merged 4 commits into from
Dec 14, 2022
Merged

Allow script/style before html #666

merged 4 commits into from
Dec 14, 2022

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Dec 9, 2022

Changes

Testing

Wasm test added

Docs

Bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2022

🦋 Changeset detected

Latest commit: a35a27d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@jasikpark jasikpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't fully understand the parser code, but the test looks like it validates the bugfix 👍

@natemoo-re natemoo-re merged commit 24dcf7e into main Dec 14, 2022
@natemoo-re natemoo-re deleted the fix/script-before-html branch December 14, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client side script inside layout file makes html lang attribute disappear
2 participants