Simplify HMR for circular imports and CSS #9706
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR removes a good portion of the HMR code with an approach that lets Vite invalidates the modules accordingly instead. The highlights are:
handleHotUpdate
. It now only does two things: "check style-only updates" and "handle circular dep edge case" (latter can be removed in the future)import.meta.hot.decline()
calls. They don't work in Vite.Testing
Added a test from #9370
While this should fix it #9370, I'd like to further improve HMR more noted in the
TODO
s, including:Docs
n/a. should be internal refactor and HMR will work as expected