fix(rss): make title optional if description is provided

[florian-lefebvre]

Changes

• Close The RSS spec does not require an item title, but astrojs/rss does #9577

Testing

Updated tests

Docs

withastro/docs#6154

[changeset-bot]

🦋 Changeset detected

Latest commit: 1666e75

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Princesseuh]

Seems like there's a test that see if we throw an error on title, should probably be removed!

[MoustaphaDev]

LGTM!

[bluwy]

Following #9577 (comment), could we also make pubDate and link optional? We'd also need to update this error message:

astro/packages/astro-rss/src/index.ts

Lines 117 to 123 in 2814984

	if (path === 'items' && code === 'invalid_union') {
	return [
	message,
	`The \`items\` property requires properly typed \`title\`, \`pubDate\`, and \`link\` keys.`,
	`Check your collection's schema, and visit https://docs.astro.build/en/guides/rss/#generating-items for more info.`,
	].join('\n');
	}

And possibly handling for undefined title and link here. (Maybe title is already fine with undefined, but maybe a test to make sure would be nice)

astro/packages/astro-rss/src/index.ts

Lines 212 to 221 in 2814984

	root.rss.channel.item = items.map((result) => {
	// If the item's link is already a valid URL, don't mess with it.
	const itemLink = isValidURL(result.link)
	? result.link
	: createCanonicalURL(result.link, rssOptions.trailingSlash, site).href;
	const item: any = {
	title: result.title,
	link: itemLink,
	guid: { '#text': itemLink, '@_isPermaLink': 'true' },
	};

[florian-lefebvre]

Since it depends on link, I add it here. But I don't know if this property is supposed to be something else when there is no link

[bluwy]

Looks great! Thanks for fixing the other fields as well.

[robmen]

Minor nit: I think should fail should be should not fail to correctly match the behavior of the test.

[florian-lefebvre]

Yes you're right! Feel free to submit a PR

[robmen]

Done. See #9646

[robmen]

@florian-lefebvre I was looking closer at this fix to learn from it and I think there is a typo in the description of the test. See comment review above. Minor nit.