chore: improve type fidelity for internal error class #9478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7470d29 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
ematipico
approved these changes
Dec 19, 2023
packages/astro/src/content/utils.ts
Outdated
| @@ -492,7 +492,7 @@ export async function getEntrySlug({ | |||
| contents = await fs.promises.readFile(fileUrl, 'utf-8'); | |||
| } catch (e) { | |||
| // File contents should exist. Raise unexpected error as "unknown" if not. | |||
| throw new AstroError(AstroErrorData.UnknownContentCollectionError, { cause: e }); | |||
There was a problem hiding this comment.
I still don't understand why the second argument is undefined 🤔
There was a problem hiding this comment.
That is the message.
const error = new Error("error message", { cause })AstroError's constructor overrides the message (this.message = errorData.message) anyway so it might be possible to remove the option altogether.
There was a problem hiding this comment.
I was a bit worried but it was relatively simple.
github-actions
bot
added
the
pr: docs
Princesseuh
approved these changes
Dec 19, 2023
lilnasy
commented
Dec 19, 2023
| @@ -226,7 +226,6 @@ export async function generateImagesForPath( | |||
| ...AstroErrorData.CouldNotTransformImage, | |||
| message: AstroErrorData.CouldNotTransformImage.message(originalFilePath), | |||
| }, | |||
| undefined, | |||
There was a problem hiding this comment.
how did tsc miss this?
lilnasy
force-pushed
the
report-error-cause
branch
from
e7eef4e to
7470d29
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
None as this is a maintainer QOL change mostly.
Docs
Does not affect usage.