-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove remaining deprecated APIs #9263
Conversation
🦋 Changeset detectedLatest commit: e7b5a49 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -18,7 +17,6 @@ import { pluginSSR, pluginSSRSplit } from './plugin-ssr.js'; | |||
|
|||
export function registerAllPlugins({ internals, options, register }: AstroBuildPluginContainer) { | |||
register(pluginComponentEntry(internals)); | |||
register(pluginAliasResolve(internals)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a silent change that's not documented in the changesets as it's fixed from a Vite 5 upgrade. Users shouldn't notice importing components with aliases not working.
@@ -292,6 +292,7 @@ export const InvalidGetStaticPathsReturn = { | |||
|
|||
/** | |||
* @docs | |||
* @deprecated Deprecated since Astro 4.0. The RSS helper no longer exists with an error fallback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes all look good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fabulous, @bluwy ! 🥳 just one typo!
Co-authored-by: Sarah Rainsberger <[email protected]>
Thanks everyone for the quick reviews 🙌 |
Changes
The changesets should explain the remaining various removals:
Testing
Existing tests should pass
Docs
Added changesets and deprecated one error code.