Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining deprecated APIs #9263

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Remove remaining deprecated APIs #9263

merged 4 commits into from
Dec 1, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Dec 1, 2023

Changes

The changesets should explain the remaining various removals:

  • The Astro preview server now returns a 404 status instead of a 301 redirect when requesting assets from the public directory without a base.
  • Removes special handling when referencing the astro/client-image type. You should use the astro/client type instead.
  • Removes deprecated builtin rss support. You should use @astrojs/rss instead.
  • Removes deprecated Astro.request.params support. You should use Astro.params instead.
  • Remove @astrojs/markdoc compat support for Astro 3
  • Removes the deprecated @astrojs/vercel/edge export.

Testing

Existing tests should pass

Docs

Added changesets and deprecated one error code.

Copy link

changeset-bot bot commented Dec 1, 2023

🦋 Changeset detected

Latest commit: e7b5a49

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Dec 1, 2023
@@ -18,7 +17,6 @@ import { pluginSSR, pluginSSRSplit } from './plugin-ssr.js';

export function registerAllPlugins({ internals, options, register }: AstroBuildPluginContainer) {
register(pluginComponentEntry(internals));
register(pluginAliasResolve(internals));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a silent change that's not documented in the changesets as it's fixed from a Vite 5 upgrade. Users shouldn't notice importing components with aliases not working.

@@ -292,6 +292,7 @@ export const InvalidGetStaticPathsReturn = {

/**
* @docs
* @deprecated Deprecated since Astro 4.0. The RSS helper no longer exists with an error fallback.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes all look good to me!

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Mic drop

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fabulous, @bluwy ! 🥳 just one typo!

.changeset/green-parrots-brake.md Outdated Show resolved Hide resolved
@bluwy
Copy link
Member Author

bluwy commented Dec 1, 2023

Thanks everyone for the quick reviews 🙌

@bluwy bluwy merged commit 3cbd8ea into main Dec 1, 2023
14 checks passed
@bluwy bluwy deleted the remove-remaining-deprecated branch December 1, 2023 16:59
This was referenced Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants