Logging rewrite 2 #9105
Merged
Logging rewrite 2 #9105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3d91174 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: integration
FredKSchott
force-pushed
the
logging-rewrite-2
branch
from
0a35e8d to
01a7e45
Compare
github-actions
bot
added
pr: docs
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Princesseuh
reviewed
Nov 15, 2023
matthewp
approved these changes
Nov 15, 2023
Princesseuh
reviewed
Nov 15, 2023
bluwy
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Like the new logs! I've create a new next branch that you can merge this into now
Princesseuh
reviewed
Nov 16, 2023
FredKSchott
force-pushed
the
logging-rewrite-2
branch
from
99baa4f to
7fc7eb0
Compare
FredKSchott
force-pushed
the
logging-rewrite-2
branch
from
7fc7eb0 to
2987c29
Compare
add back warning for header access improve labels and formatting improve error logging remove outdated error fix build new error messages and hints new error messages and hints
Co-authored-by: Erika <[email protected]>
FredKSchott
force-pushed
the
logging-rewrite-2
branch
from
2987c29 to
3d91174
Compare
|
tests passing! merging into |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Waiting to enter
4.0beta period before merging this PR. If it gets out of date withmain, it can be rebased (by @FredKSchott if the merge conflicts are non-trivial).Changes
A re-attempt at #8833, scoped down.
See this comment for context: #8833 (comment)
[label]information from most logsBetter Errors:These changes introduced in Logging refresh #8833 have been reverted, and are no longer included in this PR.(x2),(x3), etc. effect in the dev serverVideos
logging-rewrite-old.mp4
logging-rewrite-new.mp4
Note: All error-related changes have been removed from this PR and are out-of-date in the videos above.
Screenshots
Example:
(xN)Formatting WeirdnessRewriting the CLI output would cause weird formatting issues sometimes. In this example, resizing the CLI window did it.
Example: Consistent Formatting
Before
After
Build Output
Mainly stylistic, colors changed intentionally.
Before
After
Testing
Docs