Support formmethod and formaction in ViewTransitions #9084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8a9eb44 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
github-actions
bot
added
the
pr: docs
ematipico
approved these changes
Nov 13, 2023
| @@ -88,11 +88,14 @@ const { fallback = 'animate', handleForms } = Astro.props; | |||
| } | |||
|
|
|||
| const form = el as HTMLFormElement; | |||
| const submitter: HTMLButtonElement | null = ev.submitter as any; | |||
There was a problem hiding this comment.
Is any the correct type? Should it be unknown?
There was a problem hiding this comment.
I was being too clever with types, didn't need it, so removed it.
| const formData = new FormData(form); | ||
| // Use the form action, if defined, otherwise fallback to current path. | ||
| let action = form.action ?? location.pathname; | ||
| let action = submitter?.getAttribute('formaction') ?? form.action ?? location.pathname; |
There was a problem hiding this comment.
Suggested change
| let action = submitter?.getAttribute('formaction') ?? form.action ?? location.pathname; | |
| const action = submitter?.getAttribute('formaction') ?? form.action ?? location.pathname; |
There was a problem hiding this comment.
action is mutated in an if after this.
Co-authored-by: Emanuele Stoppa <[email protected]>
Merged
natemoo-re
pushed a commit
that referenced
this pull request
Nov 22, 2023
* Support formmethod and formaction in ViewTransitions * Adding a changeset * Update .changeset/new-pets-fail.md Co-authored-by: Emanuele Stoppa <[email protected]> * Be less clever --------- Co-authored-by: Emanuele Stoppa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
<button type="submit" formmethod="post" formaction="/other">.Testing
Docs
N/A, bug fix