test: add test setup for dev overlay #8932
Conversation
🦋 Changeset detectedLatest commit: 4ae3a59 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
⚖️ Bundle Size CheckLatest commit: 4ae3a59
|
| .section-content { | ||
| max-height: 250px; | ||
| overflow-y: scroll; | ||
| } |
There was a problem hiding this comment.
The virtual Playwright window is quite small, and somehow in some cases it couldn't see the tooltip. This is generally just a good change, because the tooltip could get quite long (ex: the docs sidebars)
| @@ -30,7 +30,7 @@ export class DevOverlayWindow extends HTMLElement { | |||
| font-family: ui-sans-serif, system-ui, -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, "Noto Sans", sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji"; | |||
| color: rgba(204, 206, 216, 1); | |||
| position: fixed; | |||
| z-index: 9999999999; | |||
| z-index: 999999999; | |||
There was a problem hiding this comment.
This caused the window to appear over the dev overlay, which made it impossible to click.
There was a problem hiding this comment.
Might be nice to extract each z-index we need to a custom property at the root of the dev overlay component? Then this would be slightly easier to manage in one place.
If there's a good reason you're not already doing that, ignore me!
There was a problem hiding this comment.
There's no reason not to, I think. Will refactor in a separate PR!
github-actions
bot
added
the
pr: docs
Changes
Wow, E2E tests are annoying.
Testing
It's all tests!
Docs
N/A