Fix dev overlay UI Toolkit component names #8928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 74a6601 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
sarah11918
reviewed
Oct 26, 2023
There was a problem hiding this comment.
Thanks for noticing this @HiDeoo ! Corresponding docs PR has already been approved, so feel free to merge that one whenever this one is ready. (Tiny changeset suggestion)
Co-authored-by: Sarah Rainsberger <[email protected]>
natemoo-re
approved these changes
Oct 27, 2023
Merged
natemoo-re
added a commit
that referenced
this pull request
Nov 22, 2023
Co-authored-by: Sarah Rainsberger <[email protected]> Co-authored-by: Nate Moore <[email protected]> Co-authored-by: Erika <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR renames various dev overlay UI Toolkit components to fix a name discrepancy between the code and the docs.
For example, the docs mention
astro-dev-overlay-windowbut the component was registered asastro-overlay-window. After checking with @Princesseuh on Discord, the-devportion of the name is desired.Testing
altattribute too).astro-overlay-in the codebase and no results were found.Docs
/cc @withastro/maintainers-docs for feedback!
patchfor now.-devcomponent name was used.I'll make a PR for this right after this one.Opened Fix dev overlay UI Toolkit component names docs#5206