Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(assets): Fallback format not being taken into account properly #8842

Merged
merged 6 commits into from
Oct 16, 2023

Conversation

Princesseuh
Copy link
Member

Changes

What the title says.

This PR also adds an error message when converting from SVGs to raster formats because it's easier to do by accident on the Picture component

Testing

Added a test

Docs

N/A apart from the new error

@Princesseuh Princesseuh requested a review from a team as a code owner October 15, 2023 21:33
@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2023

🦋 Changeset detected

Latest commit: 234da07

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 15, 2023
packages/astro/components/Picture.astro Outdated Show resolved Hide resolved
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just standardizing our verb tense for the changeset, otherwise, docs approves!

I realized we don't have this guidance in our actual image page in docs, so I'm making myself a task to add that info in.

.changeset/dull-bikes-decide.md Outdated Show resolved Hide resolved
@Princesseuh Princesseuh merged commit b405b03 into main Oct 16, 2023
@Princesseuh Princesseuh deleted the fix/fallback-picture branch October 16, 2023 15:43
@astrobot-houston astrobot-houston mentioned this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants