-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(assets): Fallback format not being taken into account properly #8842
Conversation
🦋 Changeset detectedLatest commit: 234da07 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Florian Lefebvre <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just standardizing our verb tense for the changeset, otherwise, docs approves!
I realized we don't have this guidance in our actual image page in docs, so I'm making myself a task to add that info in.
Co-authored-by: Sarah Rainsberger <[email protected]>
Changes
What the title says.
This PR also adds an error message when converting from SVGs to raster formats because it's easier to do by accident on the Picture component
Testing
Added a test
Docs
N/A apart from the new error