Add support for an --outDir CLI flag to astro build#8808
Merged
Conversation
🦋 Changeset detectedLatest commit: cad1013 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
natemoo-re
approved these changes
Oct 11, 2023
Member
natemoo-re
left a comment
natemoo-re
left a comment
There was a problem hiding this comment.
Works for me, thanks for the PR!
sarah11918
reviewed
Oct 11, 2023
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
yanthomasdev
approved these changes
Oct 11, 2023
Merged
Member
|
@delucis have you tested this locally at least? |
Member
Author
Yup! I built and packed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Passes the value of an
--outDirCLI flag through to Astro config, so you can set the build output directory from the command line:I also took a look through the other config options that aren’t currently available as CLI flags. Only
srcDirandpublicDirfelt like potential candidates, but those also both feel like fairly rare options, so chose to only addoutDiras part of this PR.Testing
There don’t seem to be any tests for
astro buildas far as I can tell? So not sure how to test exactly.Docs
This will need documenting in the CLI reference docs.
/cc @withastro/maintainers-docs for feedback!