Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Markdoc Integration build when root folder contains spaces #8759

Merged
merged 6 commits into from
Oct 27, 2023
Merged

Fix: Markdoc Integration build when root folder contains spaces #8759

merged 6 commits into from
Oct 27, 2023
+90 −2

Conversation

lutaok
Copy link
Contributor

@lutaok lutaok commented Oct 5, 2023 •
edited by natemoo-re
Loading

Hello,
opening this PR. Fixes #8164.

Changes

  • Added decodeURI function call to pathnames representing root folder in markdoc plugin

Testing

  • Added a test case for rendering and building with a root project folder that contains spaces
  • Manually tested with an existing markdoc project with same characteristics:
    • pnpm link on local Astro project containing fix
    • astro build on the existing project
    • No errors shown, build completed successfully

Docs

  • No workaround needed for the root project folder's name
  • No docs were added because this issue wasn't showing on docs

@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: c72ffde

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Oct 5, 2023
@lutaok lutaok requested a review from bluwy October 21, 2023 16:41
lilnasy
lilnasy approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@lilnasy lilnasy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it took a while.
LGTM, thanks for the test as well!

@github-actions github-actions bot added the pr: docs A PR that includes documentation for review label Oct 27, 2023
@bluwy bluwy merged commit 01c8011 into withastro:main Oct 27, 2023
13 checks passed
@bluwy
Copy link
Member

bluwy commented Oct 27, 2023

Thanks for fixing this!

@astrobot-houston astrobot-houston mentioned this pull request Oct 27, 2023
Merged
@natemoo-re
Copy link
Member

Closes #8164

natemoo-re pushed a commit that referenced this pull request Nov 22, 2023
@lutaok @lilnasy @natemoo-re
Fix: Markdoc Integration build when root folder contains spaces (#8759)
26a3f34 
Co-authored-by: Arsh <[email protected]>
@bluwy bluwy mentioned this pull request Jan 3, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilnasy lilnasy lilnasy approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
pkg: integration Related to any renderer integration (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spaces in project path break Markdoc integration
4 participants
@lutaok @bluwy @natemoo-re @lilnasy