-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve create-astro
startup performance
#8456
Conversation
🦋 Changeset detectedLatest commit: 8a35fb8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3654604
to
6a73dcf
Compare
🦋 Changeset detectedLatest commit: beaba06 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
!preview perf |
|
!preview perf |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a slight preference to not clear the console for pnpm and the houston message as it makes the CLI jump around and potentially hides important information. But not a blocker for this PR.
39c4ff2
to
8a35fb8
Compare
I've definitely seen users report losing something in their history that they needed or wanted from a console.clear() (IIRC snowpack used to do this in it's dev server output and we removed it for this reason). The subjective value of clearing out the npm/pnpm/yarn install noise doesn't outweigh the objective risk of losing useful data from the user's terminal history. Similar to others this isn't a huge deal / something that will break immediately, but having gone through the full process of adding and removing something like this before I'd definitely recommend reverting the |
Changes
create-astro
startup on async network requestsconsole.clear()
call at start because PNPM always spits out a bunch of dependencies duringpnpm create astro
.Testing
Tested manually. Existing test suite should work!
Before
time pnpm create astro
2.03s to first messageAfter
time pnpm create astro@next--perf
1.32s to first messageDocs
N/A