Fix markdown page HMR #8418
Merged
Fix markdown page HMR #8418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e4a7534 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
matthewp
approved these changes
Sep 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fix #8378
The JSX refactor PR updated vite-plugin-markdown so it returns an Astro component instance. When rendering Astro components, head is not rendered by default unless it calls
renderHeadormaybeRenderHead, which it doesn't.This PR adds it to preserve the previous behaviour, and to fix the HMR issue.
Before the PR, markdown pages return non-Astro components and it has automatic head rendering, denoted by the
astro.needsHeadRenderingsymbol. So it worked before.Testing
Added a new test to ensure to Vite script is added.
Docs
n/a. bug fix.