fix(ssr): inline middleware during the build, not rely on file system #8300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pkg: integration
🦋 Changeset detectedLatest commit: 09cc231 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthewp
approved these changes
Aug 30, 2023
natemoo-re
reviewed
Aug 30, 2023
Member
natemoo-re
left a comment
natemoo-re
left a comment
There was a problem hiding this comment.
This seems reasonable! Still see a few changes to be cleaned up.
natemoo-re
approved these changes
Aug 30, 2023
Merged
ematipico
added a commit
that referenced
this pull request
Feb 6, 2025
…#8300) * fix(ssr): inline middleware during the build, not rely on file system * feedback * chore: fix lint --------- Co-authored-by: Nate Moore <nate@astro.build> Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #8299
Reverts part of changes of #8200
We can't load the middleware using a file system path because, in adapters like Vercel, the bundled files are eventually moved. For other adapters like cloudflare, that is not permitted.
Testing
Current tests should pass.
I also tested locally and checked that the middleware is correctly bundled in SSR.
Docs
N/A