Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update config error message for outDir infinity loop error #8220

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Update config error message for outDir infinity loop error #8220

merged 2 commits into from
Aug 25, 2023

Conversation

andremralves
Copy link
Contributor

Changes

Related to: #8152

Just updating the error message with the suggested one.

Testing

n/a

Docs

n/a

@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8168fc7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 24, 2023
@ematipico
Copy link
Member

cc @withastro/maintainers-docs

Could you please review the error message?

ElianCodes
ElianCodes reviewed Aug 25, 2023
View reviewed changes
Copy link
Member

@ElianCodes ElianCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit! Good to merge after suggestion merge!

packages/astro/src/core/config/schema.ts Outdated Show resolved Hide resolved
packages/astro/test/units/config/config-validate.test.js Outdated Show resolved Hide resolved
@ematipico ematipico merged commit 2c07656 into withastro:main Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElianCodes ElianCodes ElianCodes left review comments

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andremralves @ematipico @ElianCodes