-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Bun detection #8219
Improve Bun detection #8219
Conversation
- Replace preferred-pm and which-pm with @skarab/detect-package-manager for improved package detection. - Standardize variable naming by switching from pkgManager to packageManager for consistency. - Update logic in next-steps.ts to reflect the changes.
🦋 Changeset detectedLatest commit: a294350 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks for this! Going to give it a proper review as soon as I can but the refactors seem great at first glance. We just merged a large working branch ( |
should I close this (again) and create a new one? I didn't read the part about creating a separate branch of the project 😅 |
Changes
Swapped out the preferred-pm and which-pm packages and replaced them with @skarab/detect-package-manager.
Standardized variable naming by changing all instances of pkgManager to packageManager to ensure consistent wording throughout the codebase.
Modified the next-steps.ts file in the create-astro package to accommodate the aforementioned changes.
These changes aim to streamline package detection (particularly Bun), enhance naming clarity, and optimize the logic in next-steps.ts for the create-astro package.
Testing
Manually tested. Here's a screenshot.
Docs
Should work as shown in https://docs.astro.build/en/recipes/bun/