Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Bun detection #8219

Closed
wants to merge 9 commits into from
Closed

Improve Bun detection #8219

wants to merge 9 commits into from

Conversation

jacobdalamb
Copy link
Contributor

Changes

Swapped out the preferred-pm and which-pm packages and replaced them with @skarab/detect-package-manager.

Standardized variable naming by changing all instances of pkgManager to packageManager to ensure consistent wording throughout the codebase.

Modified the next-steps.ts file in the create-astro package to accommodate the aforementioned changes.

These changes aim to streamline package detection (particularly Bun), enhance naming clarity, and optimize the logic in next-steps.ts for the create-astro package.

Testing

Manually tested. Here's a screenshot.
works

Docs

Should work as shown in https://docs.astro.build/en/recipes/bun/

Jacob Lamb added 3 commits August 24, 2023 11:52
- Replace preferred-pm and which-pm with @skarab/detect-package-manager for improved package detection.
- Standardize variable naming by switching from pkgManager to packageManager for consistency.
- Update logic in next-steps.ts to reflect the changes.
@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2023

🦋 Changeset detected

Latest commit: a294350

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: create-astro Related to the `create-astro` package (scope) pkg: astro Related to the core `astro` package (scope) labels Aug 24, 2023
@natemoo-re
Copy link
Member

natemoo-re commented Aug 25, 2023

Thanks for this! Going to give it a proper review as soon as I can but the refactors seem great at first glance.

We just merged a large working branch (next) into main in preparation for the 3.0 release next week, so this probably needs to be rebased. Happy to help if you run into trouble!

@jacobdalamb
Copy link
Contributor Author

Thanks for this! Going to give it a proper review as soon as I can but the refactors seem great at first glance.

We just merged a large working branch (next) into main in preparation for the 3.0 release next week, so this probably needs to be rebased. Happy to help if you run into trouble!

should I close this (again) and create a new one? I didn't read the part about creating a separate branch of the project 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants