Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@astrojs/node): handler should work with express #8176

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

ematipico
Copy link
Member

Changes

Closes #7870

Testing

I added a new test case that uses express directly.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2023

🦋 Changeset detected

Latest commit: 5d1e1d8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Aug 21, 2023
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice test

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great test, thanks for fixing!

@ematipico ematipico force-pushed the fix/node-middleare-plt-820 branch from 785ca46 to 5d1e1d8 Compare August 21, 2023 16:17
@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 21, 2023
@ematipico ematipico merged commit d08c83e into main Aug 21, 2023
@ematipico ematipico deleted the fix/node-middleare-plt-820 branch August 21, 2023 16:29
This was referenced Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSR node middleware not working on Express
3 participants