Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): delegate preview's not found and error handling to core/app #8141

Merged
merged 3 commits into from
Aug 18, 2023
Merged

fix(node): delegate preview's not found and error handling to core/app #8141

merged 3 commits into from
Aug 18, 2023

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Aug 18, 2023

Changes

  • Closes 404 page doesn't render in production mode #8054
  • Cause: the preview entrypoint passed a callback to nodeMiddleware, which overrode the recently refactored 404/500 handling.
  • Fix: removed the callback to let src/core/app handle 404 and 500.

Testing

Tested manually

Docs

Does not affect usage

@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: e658e1a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Aug 18, 2023
natemoo-re
natemoo-re approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice! Great to remove that special handling!

@natemoo-re natemoo-re merged commit 4c15c06 into withastro:main Aug 18, 2023
@astrobot-houston astrobot-houston mentioned this pull request Aug 18, 2023
Merged
@lilnasy lilnasy deleted the fix-8054 branch August 22, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees
No one assigned
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

404 page doesn't render in production mode
2 participants
@lilnasy @natemoo-re