Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Vercel Edge adapter #8015

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Remove the Vercel Edge adapter #8015

merged 4 commits into from
Aug 10, 2023

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Aug 9, 2023

Changes

  • Removes the `@astrojs/vercel/edge adapter, advices people to use Serverless + Edge Middleware instead.

Testing

  • Tests updated

Docs

  • Readme docs updated
  • Changeset used as breaking change notification.

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 894f4de

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Aug 9, 2023
@matthewp matthewp marked this pull request as ready for review August 9, 2023 21:10
@matthewp matthewp requested a review from a team as a code owner August 9, 2023 21:10
sarah11918
sarah11918 reviewed Aug 10, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think showing a recommendation re: what to do now that this is gone is helpful, too! Something in the style of below. (Update it as required for technical accuracy).

.changeset/plenty-keys-add.md Outdated Show resolved Hide resolved
natemoo-re
natemoo-re approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 to Sarah's comment! Otherwise LGTM.

@matthewp matthewp merged commit 9cc4e48 into next Aug 10, 2023
@matthewp matthewp deleted the remove-vercel-edge branch August 10, 2023 17:12
@astrobot-houston astrobot-houston mentioned this pull request Aug 10, 2023
Merged
@ematipico ematipico mentioned this pull request Aug 28, 2023
Closed
1 task
@bogdaaamn bogdaaamn mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

@natemoo-re natemoo-re natemoo-re approved these changes

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthewp @ematipico @sarah11918 @natemoo-re