-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor MDX components exports handling #7904
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9e17ffb The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: integration
Related to any renderer integration (scope)
pkg: astro
Related to the core `astro` package (scope)
labels
Aug 1, 2023
bluwy
force-pushed
the
mdx-components-exports
branch
from
August 1, 2023 15:14
53491b5
to
8cef964
Compare
github-actions
bot
added
pkg: svelte
Related to Svelte (scope)
pkg: vue
Related to Vue (scope)
pkg: example
Related to an example package (scope)
🚨 action
Modifies GitHub Actions
pkg: react
Related to React (scope)
pkg: preact
Related to Preact (scope)
pkg: solid
Related to Solid (scope)
pkg: lit
Related to Lit (scope)
pkg: create-astro
Related to the `create-astro` package (scope)
labels
Aug 1, 2023
bluwy
force-pushed
the
mdx-components-exports
branch
from
August 1, 2023 15:17
8cef964
to
80ca248
Compare
github-actions
bot
removed
pkg: svelte
Related to Svelte (scope)
pkg: vue
Related to Vue (scope)
pkg: example
Related to an example package (scope)
🚨 action
Modifies GitHub Actions
pkg: react
Related to React (scope)
pkg: preact
Related to Preact (scope)
pkg: solid
Related to Solid (scope)
pkg: lit
Related to Lit (scope)
pkg: create-astro
Related to the `create-astro` package (scope)
labels
Aug 1, 2023
ematipico
approved these changes
Aug 1, 2023
natemoo-re
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! That's a great change.
Merged
ematipico
pushed a commit
that referenced
this pull request
Aug 3, 2023
ematipico
pushed a commit
that referenced
this pull request
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg: astro
Related to the core `astro` package (scope)
pkg: integration
Related to any renderer integration (scope)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Move
export const components
MDX feature handling from Astro core to MDX integration.Testing
Existing Astro and MDX tests should pass.
Docs
n/a. Should be transparent when upgraded to latest. Will note in the migration guide issue as so.