Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump esbuild version to 0.18 #7830

Closed
wants to merge 6 commits into from
Closed

bump esbuild version to 0.18 #7830

wants to merge 6 commits into from

Conversation

mayank99
Copy link
Contributor

@mayank99 mayank99 commented Jul 26, 2023

Changes

updated astro > esbuild from 0.17 to 0.18

vite 4.4 uses esbuild 0.18, so installing astro was resulting in two versions of esbuild inside node_modules.

i believe no code changes are necessary as they were already handled in #7479/#7746

Testing

N/A. no code changes.

Docs

N/A. no code changes.

@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2023

🦋 Changeset detected

Latest commit: cf80ebf

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 26, 2023
@mayank99 mayank99 changed the title bump esbuild version to 0.18.x. bump esbuild version to 0.18 Jul 26, 2023
@mayank99
Copy link
Contributor Author

not sure why test is failing

@astrojs/mdx:test: Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'mdast' imported from /Users/runner/work/astro/astro/packages/integrations/mdx/dist/remark-images-to-component.js

looks unrelated to esbuild

@natemoo-re
Copy link
Member

not sure why test is failing

@astrojs/mdx:test: Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'mdast' imported from /Users/runner/work/astro/astro/packages/integrations/mdx/dist/remark-images-to-component.js

Ah we've had some weird problems with this one before. I can take a look.

Thanks for the PR!

@mayank99
Copy link
Contributor Author

Closing because esbuild 0.19 is already out. Hopefully astro will bump at some point

@mayank99 mayank99 closed this Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants